Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 158805 - Provide builds of RCP platform for GMF editors
Summary: Provide builds of RCP platform for GMF editors
Status: RESOLVED FIXED
Alias: None
Product: GMP
Classification: Modeling
Component: Releng (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Richard Gronback CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 114200
  Show dependency tree
 
Reported: 2006-09-26 12:56 EDT by Dmitry Stadnik CLA
Modified: 2010-07-19 22:07 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Stadnik CLA 2006-09-26 12:56:28 EDT
GMF Tooling should support RCP option and thus needs an RCP runtime to host 
generated code. This runtime consists of the following pieces:
1. Eclipse RCP + plugins required by GMF runtime such as 
org.eclipse.core.resources
2. EMF plugins that do not require Eclipse IDE
3. Draw2D, GEF, EMFT
4. GMF runtime without *.ide plugins

I suggest to provide zip files with all these plugins packaged in one 
distribution since:
1. They define what we mean under "RCP" term )))
2. It takes time to figure out all the dependencies and pack such RCP runtime; 
it's error-prone and time-consuming process that should be automated
Comment 1 Richard Gronback CLA 2006-11-13 12:53:01 EST
I'm not sure why this issue blocks 114200.  As I see it, we need to create an org.eclipse.gmf.runtime.rcp-feature that lists the minimally required/included features/plug-ins.  Providing a single bundle of these is easily handled by the build, but we'll need the list of the exact features/plug-ins to include (hence, the o.e.g.runtime.rcp-feature manifest), which should come as a result of your target config when generating a basic RCP-ish graphical diagram, right?

Similarly, we should provide this for the "lite" runtime.
Comment 2 Dmitry Stadnik CLA 2006-11-15 06:48:31 EST
I think that this request is a part of req described in 114200 and in this sense it "blocks" it but actually there is just a dependency. I thought that depends/blocks fields are ok to express this.

I'll enumerate required plugins.
Comment 3 Dmitry Stadnik CLA 2006-11-28 11:49:32 EST
GMF Runtime plugins for RCP:

org.eclipse.gmf.runtime.common.core
org.eclipse.gmf.runtime.common.ui
org.eclipse.gmf.runtime.common.ui.action
org.eclipse.gmf.runtime.common.ui.printing
org.eclipse.gmf.runtime.common.ui.services
org.eclipse.gmf.runtime.common.ui.services.action
org.eclipse.gmf.runtime.common.ui.services.dnd
org.eclipse.gmf.runtime.common.ui.services.properties
org.eclipse.gmf.runtime.diagram.core
org.eclipse.gmf.runtime.diagram.ui
org.eclipse.gmf.runtime.diagram.ui.actions
org.eclipse.gmf.runtime.diagram.ui.dnd
org.eclipse.gmf.runtime.diagram.ui.geoshapes
org.eclipse.gmf.runtime.diagram.ui.printing
org.eclipse.gmf.runtime.diagram.ui.printing.render
org.eclipse.gmf.runtime.diagram.ui.properties
org.eclipse.gmf.runtime.diagram.ui.providers
org.eclipse.gmf.runtime.diagram.ui.render
org.eclipse.gmf.runtime.diagram.ui.resources.editor
org.eclipse.gmf.runtime.draw2d.ui
org.eclipse.gmf.runtime.draw2d.ui.render
org.eclipse.gmf.runtime.draw2d.ui.render.awt
org.eclipse.gmf.runtime.emf.clipboard.core
org.eclipse.gmf.runtime.emf.commands.core
org.eclipse.gmf.runtime.emf.core
org.eclipse.gmf.runtime.emf.type.core
org.eclipse.gmf.runtime.emf.type.ui
org.eclipse.gmf.runtime.emf.ui
org.eclipse.gmf.runtime.emf.ui.properties
org.eclipse.gmf.runtime.gef.ui
org.eclipse.gmf.runtime.notation
org.eclipse.gmf.runtime.notation.edit
org.eclipse.gmf.runtime.notation.providers
Comment 4 Dmitry Stadnik CLA 2007-02-28 09:58:34 EST
I've added three features to repository: org.eclipse.emf.rcp (rcp plugins from EMF), org.eclipse.gmf.platform (extra Eclipse plugins from platform that should be added to RCP) and org.eclipse.gmf.runtime.rcp (GMF runtime rcp plugins).
Comment 5 Richard Gronback CLA 2008-08-13 13:07:55 EDT
[target cleanup] 2.1 M1 was the original target milestone for this bug
Comment 6 Richard Gronback CLA 2008-09-12 17:22:39 EDT
I'm taking a look into this again as I try to configure a 'Modeler' download for Amalgam that includes a minimal configuration for UML2 Tools diagramming.

Currently, the GMF runtime feature (org.eclipse.gmf) includes the feature org.eclipse.emf as a required dependency.  Unfortunately, this pulls in the JDT as org.eclipse.emf includes plug-in org.eclipse.emf.codegen, which has a dependency on org.eclipse.jdt.core.

Given the recent breakup of EMF's features, we should have the org.eclipse.gmf feature depend on the following EMF features instead:

org.eclipse.emf.common
org.eclipse.emf.common.ui
org.eclipse.emf.ecore
org.eclipse.emf.ecore.edit
org.eclipse.emf.edit
org.eclipse.emf.edit.ui

It seems there are only 2 more individual plug-ins (org.eclipse.emf.ecore.change, org.eclipse.emf.ecore.xmi) beyond those matching the feature names above, if we would prefer to declare plugin-level dependencies for EMF.

The org.eclipse.gmf.runtime.notation feature also has a dependency on the org.eclipse.emf feature, but could use just those plugins found in features:

org.eclipse.emf.ecore
org.eclipse.emf.ecore.edit
org.eclipse.emf.edit

Anthony, do you have any problem with changing the EMF feature dependencies to match the list above instead of using org.eclipse.emf?

In keeping with Dmitry's initial motivation for this bug, perhaps we could also define and include an org.eclipse.gmf.runtime.rcp feature that would facilitate the build and installation of RCP-based diagram editors?  I'm not sure we need the *.platform and *.emf.rcp features Dmitry initial contributed, as the specified plug-ins can be listed as dependencies of an runtime.rcp feature.  p2 based builds and product configurations can pull in dependent plug-ins without a need for fine-grained features for everything.

Comment 7 Anthony Hunter CLA 2008-09-13 23:01:08 EDT
(In reply to comment #6)
> Anthony, do you have any problem with changing the EMF feature dependencies to
> match the list above instead of using org.eclipse.emf?

Yes, we have no problem doing this. This is Bug 207234 .
	

Comment 8 Richard Gronback CLA 2008-09-15 12:11:22 EDT
Committed updated feature dependencies to R2_1_maintenance and HEAD for runtime and included notation features, as indicated.  I also bumped the EMF version to 2.4.0 to align with actual plugin versions specified.

I'm closing this bug, as it's straightforward to produce a product build for an RCP-based diagram.  The build will only include those features/versions required, so a separate build is not really required.  Just URLs to Eclipse or local repositories are needed. 
Comment 9 Eclipse Webmaster CLA 2010-07-16 23:35:17 EDT
[target cleanup] 2.2 M2 was the original target milestone for this
bug
Comment 10 Eclipse Webmaster CLA 2010-07-19 22:07:09 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Releng was the original product and component for this bug