Community
Participate
Working Groups
platform/org.eclipse.hyades.execution/src-iac-native This patch includes some generic fixes (missing system header file inclusion causing warnings) and also a new makefile for x86_64 support. It is also advised that the "-fPIC" option be used with GCC when creating shared libraries. I notice at the bottom of makefile.linux.x86 there is the line: zip iac.linux_ia32.zip libtptpCommon.so libtptpNP.so I have changed this to: zip iac.linux_x86.zip libtptpCommon.so libtptpNP.so There term "ia32" refers to the classical 8086/80386 archetecture cpus and is too generic in the context its used since both the 32bit (x86) and 64bit (x86_64) are both ia32 platform cpus. The "ia64" is the Intel Itanium cpu which is a completely different instruction set. The Native system and the OSGi use the terms "x86" and "x86_64" so I would propose that the zip filename be changed from "ia32". Changing this name of the ZIP probably has knock on effect for the build process so other changes might be necessary for releng. I have also done a test compile of the tptpShm module and applied the obvious fixes for Linux but this code has obvious coding errors in tptpShm/tptpShm_md.c and given that its not in any makefile it maybe obsolete or incomplete, but accept this patch as assitance in getting it working for Linux. I intend to continue porting each of the DDL/DSO libraries listed in the MANIFEST for platform/org.eclipse.hyades.execution.linux.x86/ so that a new project platform/org.eclipse.hyades.execution.linux.x86_64/ can be created.
Created attachment 50242 [details] org.eclipse.hyades.execution_20060915.diff Linux compile improvements and x86_64 support.
Created attachment 50243 [details] platform/org.eclipse.hyades.execution/src-iac-native/makefile.linux.x86_64 New file platform/org.eclipse.hyades.execution/src-iac-native/makefile.linux.x86_64
Created attachment 50249 [details] org.eclipse.hyades.execution.linux.x86_64.zip Project Basic project based on the existing 32bit Linux project. As I have been able to build 64bit version of the native pre-requisites from parts of the agentcontroller and haydes.execution we can't be that far out from having a 64bit version. I have removed the MANIFEST entry: Bundle-NativeCode: libtptpShm.so;processor="x86_64";osname="Linux", This is because is does not look like it is built or needed anymore. I don't know what impact that has, I am looking from the point of view from CVS HEAD. Maybe the current 32bit Linux packages wants investigation.
Created attachment 50252 [details] org.eclipse.tptp.platform.agentcontroller.diff THIS PATCH NEEDS MAJOR REVIEW, ESPECIALLY THE CHANGES IN StatelessHeapSnapshotManager_C.cpp. StatelessHeapSnapshotManager_C.cpp: allow the component to compile but almost certainly create new bugs. RADataTransfer.h missing system header file to reduce compile time warnings. RAServer/messagePump.c when using GCC 4.0.2 the existing assignment would not compile but using the same assignment as _HPUX/MVS/OS400 was found to work. RAServer/messagePump.c when using GCC 4.0.2 the compiler now generates an error for labels after blocks. This is appearently a compiler extension, one workaround is to use break statements in loops. collection/include.common changes to correcty detect 64bit linux. collection/include.linux_x86_64 this is a new file to allow the 64bit build to take place.
Created attachment 50616 [details] org.eclipse.hyades.execution.linux.x86_64.zip Project Corrected initial project which includes: Bundle-NativeCode: libtptpShm.so;processor="x86_64";osname="Linux" I have sucessfully built this DSO from the project: org.eclipse.tptp.platform.agentcontroller/collection/libtptpShm.so
Created attachment 50617 [details] org.eclipse.tptp.platform.agentcontroller.diff Updated version based on CVS checkout. See Comment #4 for most notes. collection/include.linux_em64t file not included, will be attached separatly. StatelessHeapSnapshotManager_C.cpp: This still needs major review. I have sucesfully built a set of ZIPs: libtptpShm.linux_em64t.zip tptpdc.linux_em64t.zip tptpdc.linux_em64t.sdk.zip pae.linux_em64t.zip But not yet able to test as I have not found any documentation explaining how to recreate your releng build process to merge java files and other artifacts into a distributable zip. The "make package" gives me have a partial distribution.
Created attachment 50618 [details] org.eclipse.tptp.platform.agentcontroller/src-native/collection/include.linux_em64t New File New file to go with attachment #50617 [details].
Created attachment 50619 [details] org.eclipse.hyades.execution.linux.x86_64.zip Project Duh! Third time lucky. This one is tested by manually building the plugin, Bundle-NativeCode processor works with amd64 (as per the Sun JVM processor label, tested with Sun JVM 1.5.0_08) org.eclipse.hyades.execution.linux.x86_64 (4.2.0.qualifier) "TPTP Platform Execution Plug-In" [Resolved]
Samson - assigning it to you since this pertains to IAC.
Hi Darryl. This bug is currently not PMC/PG approved for TPTP 4.3 due to its "normal" severity. By default all non-critical bugs will be retargeted to TPTP 4.4 or future releases. Do you have any issue with this not being fixed in TPTP 4.3? I would say due to the changes required for the build this would be better addressed in TPTP 4.4 instead.
I didn't expect it to make 4.3. I'm happy for this to make an early weekly "towards 4.4" build. I seek to help provide feedback and bug reports for 64bit linux unfortunely TPTP isn't quite mature enough to build on top on yet, so this is my gesture to help 64bit linux support along. The sooner it gets committed into a weekly the sooner I look to see what else needs attention.
Thanks Darryl. I will target this to 4.4 and increase the severity to "major" so that it can be picked up during the next release and catch attention.
Retarget to future due to resource limitation.
Hi Bing. I have transferred my bugs to you for triage. Thanks.
It feels like musical chairs in here! Open Source by Committee of Corporations. Is there a list of committers on Eclipse projects who can actually get stuff done, the faster stuff gets done by the committers the faster contributions can flow into the product ?
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
