Description David Olsen 2006-09-13 02:50:59 EDT

PDE Build should fail whenever a CVS command fails.

Currently, PDE Build does not always fail when a CVS command fails.  Normally a CVS failure will cause a plugin or feature to be missing completely, which will stop the build pretty quickly.  But recently in our builds we have seen CVS export commands that check out a bunch of files and then fail.  PDE Build merrily continued on with the build.  Because the CVS command had done a partial export, all the files that describe the plugin (plugin.xml, MANIFEST.MF, build.properties, etc.) were present.  It was just some of the source files that were missing.  PDE Build tried to compile all the source files that were present and made no complaints about the ones that were missing.

In most cases, one of the plugins failed to compile due to the missing source files.  But we have had at least one case where the missing source files were not used by anything else within that particular build, so the build seemed to succeed.  The problem wasn't noticed until someone else tried to use the plugins that had been created.

Even though this problem is rare (and we think we have fixed our CVS server so these types of errors won't happen any more), it can lead to PDE Build silently building something incorrectly.  And that is the worst possible sin a build can commit.  That's why I think PDE Build should fail immediately whenever a CVS command returns an error.