Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 157039 - new webserviceutils.jar not copied in client generation
Summary: new webserviceutils.jar not copied in client generation
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: 1.5.1 M151   Edit
Assignee: Andrew Mak CLA
QA Contact: Chris Brealey CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-12 10:29 EDT by Andrew Mak CLA
Modified: 2006-09-22 11:12 EDT (History)
1 user (show)

See Also:

Attachments
check for webserviceutils.jar size before copy (3.34 KB, patch)
2006-09-12 13:40 EDT, Andrew Mak CLA 		no flags Details | Diff
check webserviceutils.jar size (3.38 KB, patch)
2006-09-12 15:02 EDT, Andrew Mak CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Mak CLA 2006-09-12 10:29:49 EDT 
This problem is related to bug 155439.

The scenario is similar:  The user generates a web service client with JSP test and uses an older version of the webservicesutils.jar.  They then export the project and import it to WTP 1.5 and the re-generate the client with JSP test.  There will be a compile error in the sample jsp because the webserviceutils.jar is an older version and the package name is different.
Comment 1 Chris Brealey CLA 2006-09-12 11:33:14 EDT 
Andrew, thanks, would you please propose a patch?
Comment 2 Andrew Mak CLA 2006-09-12 13:40:26 EDT 
Created attachment 49953 [details]
check for webserviceutils.jar size before copy

This patch will check the file size of the webserviceutils.jar.  We will copy the jar into the project only if the existing version's size is different from the size of the jar we intend to copy into the project.
Comment 3 Andrew Mak CLA 2006-09-12 13:43:05 EDT 
Ready for review/commit, thanks!
Comment 4 Chris Brealey CLA 2006-09-12 14:43:35 EDT 
Thanks Andrew. The only catch is that myURL.toURI() is new as of Java 5, and we need to keep ourselves compatible with Java 1.4. How about "new URI(myURL.toString())"?
Comment 5 Andrew Mak CLA 2006-09-12 15:02:04 EDT 
Created attachment 49973 [details]
check webserviceutils.jar size

Thanks for the suggestion Chris.  I have fixed the patch and re-tested it.
Comment 6 Chris Brealey CLA 2006-09-12 15:44:52 EDT 
Andrew, thanks for the revised patch. Reviewed, and looks good.

PMC, requesting approval to commit this to WTP 1.5.1.

The "Sample JSP" test facility generated by the Web service wizards consists of four JSP files and a utility jar the JSPs depend upon named webserviceutils.jar. Though rare, changes are occasionally made to the generated JSPs and the jar which, if not generated together into a target project, will result in JSP compilation failures at tool and/or app server runtime. Without the attached fix, the Web service wizards will generate the JSPs, but will not update webserviceutils.jar.

The attached fix insures that when the JSPs are written, webserviceutils.jar is also updated if necessary. The fix is simple and well tested.
Comment 7 David Williams CLA 2006-09-13 13:48:19 EDT 
+1
Comment 8 Chris Brealey CLA 2006-09-13 16:56:24 EDT 
Patch committed and released under tag v200609132055 for tonight's M-build based on David's vote. No other votes have been posted in the last 24 hours. We can revert the changes if anyone objects.
Comment 9 Naci Dai CLA 2006-09-14 11:24:20 EDT 
+1
Comment 10 Tim Wagner CLA 2006-09-14 14:46:25 EDT 
+1
Comment 11 Andrew Mak CLA 2006-09-22 11:12:46 EDT 
verified in 1.5.1 HEAD.