Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 155907 - Add support for jsp:attribute from JSP 2.0 specification
Summary: Add support for jsp:attribute from JSP 2.0 specification
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 1.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 2.0 RC0   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
: 105460 (view as bug list)
Depends on:
Blocks: 124288
  Show dependency tree
 
Reported: 2006-08-31 18:01 EDT by Riyad Kalla CLA
Modified: 2007-06-22 15:22 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Riyad Kalla CLA 2006-08-31 18:01:16 EDT
Details about jsp:attribute can be found here:
http://java.sun.com/products/jsp/syntax/2.0/syntaxref2014.html

An example page using default JSF taglibs is:
----------------------
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<html> <body>
   <f:view>      
      <f:loadBundle var="msg">
         <jsp:attribute name="basename" >test.bundle</jsp:attribute>
      </f:loadBundle>         
            
      <h:outputText value="#{msg.bla}"  />
   </f:view>
   </body>
</html> 
----------------------

Problem is that jsp:attribute is marked as warning:
----------------------
Unknown tag (jsp:attribute).
----------------------
Comment 1 David Williams CLA 2006-08-31 23:51:10 EDT
I'm a little surprised by this one, Nitin. Any thoughts if this is a bug? Or, did we just overlook it? 

Comment 2 Nitin Dahyabhai CLA 2006-09-06 05:18:38 EDT
I think at the least that we overlooked it.  Our JSP content model document doesn't include it and our translator's not incorporating it into the servlet source.
Comment 3 Nitin Dahyabhai CLA 2007-04-19 01:24:58 EDT
Fixed.  Created a separate CMDocument both for JSP 2.0 and tag files (in HTML core for now), a new modelhandler and model query for tag files to access the correct CMDocument, and changed JSPCMDocumentFactory to default to 2.0.  We also have some ability to judge which version of the spec we should be supporting for a given file.
Comment 4 Nitin Dahyabhai CLA 2007-05-02 16:39:55 EDT
*** Bug 105460 has been marked as a duplicate of this bug. ***
Comment 5 Amy Wu CLA 2007-06-22 15:22:49 EDT
verified in wtp2.0 RC4 200706212235