Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 155346 - [Viewers] Design flaws in EditingSupport?
Summary: [Viewers] Design flaws in EditingSupport?
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 155884
Blocks:
  Show dependency tree
 
Reported: 2006-08-27 17:02 EDT by Thomas Schindl CLA
Modified: 2006-10-20 09:00 EDT (History)
1 user (show)

See Also:


Attachments
Solving 1st part of the problem (3.67 KB, patch)
2006-08-27 17:06 EDT, Thomas Schindl CLA
no flags Details | Diff
Just an idea to change API! (8.78 KB, patch)
2006-08-31 16:08 EDT, Thomas Schindl CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2006-08-27 17:02:54 EDT
1. Moving of columns
At the moment EditingSupport has the design flaw that columns can not be moved. I think we also have to restore the columnIndex in a field and add getter and setter.

2. Enabling support at a later point
In former days you could add editing support at any given point in time (e.g. creating the viewer with remove it at any given point in time). This is not done automatically at the moment.
Comment 1 Thomas Schindl CLA 2006-08-27 17:06:48 EDT
Created attachment 48855 [details]
Solving 1st part of the problem

This patch only solves the first part of the problem and to some extent the second part by checking cellModifier and columnProperties
Comment 2 Thomas Schindl CLA 2006-08-31 15:55:26 EDT
After the discussion today I think we should pass ViewerCell instead of Object to  all methods. This way we don't need to cache any information.
Comment 3 Thomas Schindl CLA 2006-08-31 16:08:11 EDT
Created attachment 49213 [details]
Just an idea to change API!
Comment 4 Thomas Schindl CLA 2006-10-20 05:25:59 EDT
Could be closed.
Comment 5 Thomas Schindl CLA 2006-10-20 05:38:51 EDT
(In reply to comment #0)
> 1. Moving of columns
> At the moment EditingSupport has the design flaw that columns can not be moved.
> I think we also have to restore the columnIndex in a field and add getter and
> setter.
> 

Fixed by complete redesign of ViewerColumn, ... in the meanwhile.

> 2. Enabling support at a later point
> In former days you could add editing support at any given point in time (e.g.
> creating the viewer with remove it at any given point in time). This is not
> done automatically at the moment.

Fixed in bug #160700

> 

Comment 6 Tod Creasey CLA 2006-10-20 09:00:59 EDT
Marking INVALID as Tom has other solutions