Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 155083 - [JFace] Provide an animated tab item
Summary: [JFace] Provide an animated tab item
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement with 1 vote (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 155405 166264
Blocks: 154123
  Show dependency tree
 
Reported: 2006-08-24 14:19 EDT by Tod Creasey CLA
Modified: 2013-08-27 12:32 EDT (History)
4 users (show)

See Also:


Attachments
Patch should it need to be reverses (29.79 KB, patch)
2006-08-28 12:31 EDT, Tod Creasey CLA
no flags Details | Diff
Firefox Progress animated GIF (825 bytes, image/gif)
2006-11-29 16:34 EST, Benjamin Pasero CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-08-24 14:19:42 EDT
We should provide support for animated gifs in tab items. It is unclear whether or not we should just implement this in the presentations of if we should make it more widely available via API in workbench or JFace (we would need to use the workbench if it relies on Jobs).
Comment 1 Tod Creasey CLA 2006-08-28 11:28:54 EDT
I have done a preliminary implementation. To see this 

STEPS
1) Load org.eclipse.ui and org.eclipse.ui.workbench from head
2) Self host with the tracing enabled for org.eclipse.ui.workbench for entries debug and trace/graphics
3) Open the problems view and rebuild - you will see a spinner
Comment 2 Tod Creasey CLA 2006-08-28 12:31:02 EDT
Created attachment 48889 [details]
Patch should it need to be reverses
Comment 3 Benjamin Pasero CLA 2006-11-29 16:33:22 EST
Great work Tod, I was just giving it a try. However, I am not totally yet happy with the used image. I think usually these progress-images animate clockwise. I was experimenting with the GIF Firefox is using (find it attached). I like it very much, and its pretty much the same in iTunes as well.

I was also wondering why the tabitem's label was flickering a bit. It turns out that every call to setImage() on a CTabItem causes the entire tabitem to redraw, including the label (See Bug 166264 for more details).

Fixing Bug 166264 and using the other icon, I made a small flash-video on how its looking now over at my pc:

http://www.rssowl.org/dl/anim_tab.html

Would be awesome to see this in M4 :)

Ben
Comment 4 Benjamin Pasero CLA 2006-11-29 16:34:22 EST
Created attachment 54748 [details]
Firefox Progress animated GIF
Comment 5 Benjamin Pasero CLA 2006-11-29 16:38:42 EST
A, forgot to mention. In order to have a smooth, not too fast animation for the GIF I was using, I had to increase the sleep() in AnimatedTabItem to 100.

I know that the SWT Snippet for animated GIF suggests to use imageData.delayTime, but for some reason the GIF I was using did not return any other value than 0. I guess thats something that is easy to define in an application like photoshop or else.

Ben
Comment 6 Tod Creasey CLA 2006-11-30 08:18:28 EST
I will certianly turn it on when Bug 166464 is sorted. I will also get a better graphic - I just took one that we produce so as to avoid legal issues when doing this work.

This is cool Ben - thanks for your work.
Comment 7 Benjamin Pasero CLA 2006-11-30 09:45:44 EST
Great :)!
Comment 8 Tod Creasey CLA 2006-11-30 14:30:14 EST
Lets try for M4
Comment 9 Benjamin Pasero CLA 2006-11-30 16:07:12 EST
Cool. Does this mean it will be enabled by default in M4, or do I still have to enable tracing?
Comment 10 Tod Creasey CLA 2006-11-30 16:30:14 EST
It will be on by default.
Comment 11 Tod Creasey CLA 2006-11-30 16:39:05 EST
Fixed in build >20061130
Comment 12 Tod Creasey CLA 2006-12-12 10:50:56 EST
Verified in 20061212-0100
Comment 13 Marcos César de Oliveira CLA 2009-07-18 13:04:21 EDT
I want to use this feature in my RCP application. How can I do?
Comment 14 Andreas Ehret CLA 2011-05-05 08:40:19 EDT
Does this enhancement really find its way into Eclipse 3.6? I can't get a animated gif running in a View tab and I didn't find any code fragments in org.eclipse.ui.internal.presentations.util.WidgetTabItem using AnimatedTabItem or something similar as described in the patch. Could someone post whether this feature is really available and how it can be used?