Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 154851 - [reorg][move static members] Move constant wizard has option "Keep original method..."
Summary: [reorg][move static members] Move constant wizard has option "Keep original m...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 198391 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-23 09:28 EDT by Markus Keller CLA
Modified: 2010-05-21 11:39 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-08-23 09:28:42 EDT 
I20060822-1200

Refactor > Move a constant field.
The wizard has an option "Keep original method as delegate to moved method".
-> Should be "member", not "method"
-> Same problem when moving two constants at once
Comment 1 Dani Megert CLA 2008-07-08 04:23:38 EDT 
>-> Same problem when moving two constants at once
Comment 2 David Balažic CLA 2010-03-04 08:11:18 EST 
Still same in version 3.5.2 (Galileo SR2)
Comment 3 Raksha Vasisht CLA 2010-04-01 03:47:40 EDT 
Fixed in HEAD > N20100331-2000.
Comment 4 Markus Keller CLA 2010-04-01 08:12:26 EDT 
When you change anything that could be accessed from multiple locations, you always need to check *all* references to make sure the change makes sense everywhere.

In this case, the strings you changed in refactoring.properties are also used by the Move Instance Method wizard, and there the labels should keep saying "method".
Comment 5 Raksha Vasisht CLA 2010-04-06 03:28:59 EDT 
(In reply to comment #4)
> When you change anything that could be accessed from multiple locations, you
> always need to check *all* references to make sure the change makes sense
> everywhere.
> 
> In this case, the strings you changed in refactoring.properties are also used
> by the Move Instance Method wizard, and there the labels should keep saying
> "method".

Yes I saw that and thought "member" would cover that case as well.

Fixed in HEAD. Added separate constants for members in 

org.eclipse.jdt.internal.corext.refactoring.structure.MoveStaticMembersProcessor
/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/refactoring.properties
/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/RefactoringCoreMessages.java
Comment 6 Markus Keller CLA 2010-05-21 11:37:40 EDT 
*** Bug 313918 has been marked as a duplicate of this bug. ***
Comment 7 Markus Keller CLA 2010-05-21 11:39:39 EDT 
*** Bug 198391 has been marked as a duplicate of this bug. ***