Community
Participate
Working Groups
When editing a C/C++ file (using CDT) in the Java perspective two Open Type.. action buttons are visible in the toolbars, one for Java and one for C/C++. Two identical buttons with the same tooltip but different functions is confusing (not that mixing languages isn't). It would make sense to combine them somehow and allow other plugins to contribute their own functionality.
Related to plan item from bug 154104.
We now have an abstract class for this so that the behaviour of all the different selection dialogs can be consistent for different kinds of items being selected: See FilteredItemsSelectionDialog and its subclasses. Not sure if combining Java and C/C++ types in one dialog is the way to go. Marking this one as worksforme. If we decide to combine Java types and C/C++ types in one search, that search engine should combine even more searchable objects (help, resources, maybe even the contents of the Quick Access dialog). We should have a bug open for this one but I couldn't find it.
Perhaps I filed a possible solution rather than the problem I was trying to address. I wasn't necessarily meaning mixing types in one dialogue - that could be confusing and would probably be better suited to "Open Resource" or a new "Open Element". I suppose I was thinking of making Open Type closer to a retargetable action so the types that are shown are dependent on the context in which it the dialogue is opened (selection, focused parts, perspective etc). The problem I was trying to address was having duplicate buttons with different actions. Of course now Eclipse is becoming such a successful platform I suspect there are more things which could be abstracted out of existing plugins e.g. JDT's declaration view. Still, that's another bug, and your solution of a common selection dialogue class sounds even better than one specific to Open Type. Thanks for looking into this.
