Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 153725 - Missing NON-NLS in generated Package and EEnum literals
Summary: Missing NON-NLS in generated Package and EEnum literals
Status: RESOLVED WORKSFORME
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dave Steinberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-14 03:08 EDT by Daniel Hirscher CLA
Modified: 2006-08-14 10:03 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hirscher CLA 2006-08-14 03:08:30 EDT 
The generated Package is missing NON-NLS on: eNAME, eNS_URI and eNS_PREFIX.

The generated literal objects for EEnums are missing NON-NLS-2. Example:
   public static final LineSeparator CRLF_LITERAL = new LineSeparator(CRLF, "CRLF", "CRLF"); //$NON-NLS-1$
Comment 1 Ed Merks CLA 2006-08-14 09:26:44 EDT 
I suspect you didn't set the GenModel property Non-NLS Markers to true because these things all look fine in the templates and work fine when I tried them.
Comment 2 Daniel Hirscher CLA 2006-08-14 09:37:47 EDT 
I investigated the problem further.

- I have NON-NLS set to true in the genmodel
- some NON-NLS markers are generated, the markers mentioned above are not
- only interfaces are affected (so far)

So I did this:
- deleted the classes with the missing NON-NLS markes
- regenerated the model code
Then the markers appeared.

I suspect that the merger did not process the changes correctly.

But I can live with that.
I will now delete and recreate all that interfaces.
Comment 3 Ed Merks CLA 2006-08-14 10:03:03 EDT 
Daniel,

Yeah, non-javadoc comments outside of method bodies are tricky to merge, so that's likely a source of confusion.