Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 153583 - selection tools marquees don't draw correctly in OS X
Summary: selection tools marquees don't draw correctly in OS X
Status: RESOLVED WORKSFORME
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: 3.2   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.6.1 (Helios SR1)   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 332872
Blocks:
  Show dependency tree
 
Reported: 2006-08-11 11:10 EDT by Alberto Ricart CLA
Modified: 2011-01-06 15:16 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Ricart CLA 2006-08-11 11:10:58 EDT
The selection tools (and subtypes) don't draw a marquee correctly. The marquee uses white and transparent so on a white background you cannot see the bounds of the drag rectangle. This is evident on the Shapes sample.

The correct behaviour would be some sort XOR type drawing, so no matter the color in the background, the selection rectangle would be visible.
Comment 1 Randy Hudson CLA 2006-08-11 11:29:18 EDT
We are using XOR, the problem is that Mac OS X doesn't support it.
Comment 2 Alberto Ricart CLA 2006-08-11 11:51:29 EDT
You may want to look at carbon sketch and implement the specific selection drawing as necessary for the platform. They implement 'marching ants' in that application. 

<http://developer.apple.com/documentation/Carbon/Conceptual/QuickDrawToQuartz2D/tq_regions/chapter_8_section_3.html>

If the marching ants is not the correct ui guideline, then color the rectangle, or anything to indicate the bounds of the drag.
Comment 3 Eclipse Webmaster CLA 2007-07-29 09:20:44 EDT
Changing OS from Mac OS to Mac OS X as per bug 185991
Comment 4 Bryan Hunt CLA 2008-08-03 09:17:31 EDT
Is this something that will get fixed with the cocoa port?
Comment 5 Randy Hudson CLA 2008-08-04 10:01:47 EDT
Bryan, I don't think XOR will be supported in the Cocoa port. The best thing we can do is just check for OS X, and paint the marquee differently. This is not hard nor would it be the first place we have platform-specific code in GEF.

The only reason it hasn't been done yet is that no one has taken the time to define what the native finder marquee behavior is, and whether that would be sufficient. It appears to just be a rectangle blended using the platform selection color with a more opaque outline (maybe some shadow or highlight effect?). We can do this, but what happens when the diagram behind the marquee happens to be that color already? The rectangle would be invisible? I have an idea of what Finder does, but it works well because the content is known/limited.  What do other programs do on the Mac?  OmniGraffle? PhotoShop? PowerPoint?

Some mockups or screen captures would help move this enhancement along.
Comment 6 Bryan Hunt CLA 2009-03-20 11:03:17 EDT
Randy, will you be at EclipseCon?  Would like to talk about this bug if you have time.
Comment 7 Anthony Hunter CLA 2009-03-20 11:12:37 EDT
Hi Brian, Randy will not be at EclipseCon, but I will be (I am the GEF Project Lead). You can track me down and we can talk about this bug.

Incidentally, check out my latest blog: http://ahuntereclipse.blogspot.com/2009/03/eclipsecon-show-me-your-mac.html . 

Any help you could provide in this area would be awesome.
Comment 8 Bryan Hunt CLA 2009-03-20 11:14:51 EDT
Thanks Anthony ... I'll find you.  BTW, I've been playing with Ecore Tools on 3.5M6 Cocoa and it's working nicely.
Comment 9 Alexander Nyßen CLA 2011-01-06 13:41:26 EST
Verified that with Eclipse 3.6.1 XOR painting works fine on Mac Carbon (10.4.11, Java 5). Resolving as fixed in 3.6.1 though.
Comment 10 Randy Hudson CLA 2011-01-06 15:13:13 EST
I think the correct resolution is "WORKS FOR ME"?
Comment 11 Alexander Nyßen CLA 2011-01-06 15:16:08 EST
Here you are...