Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 150969 - store and present repository labels in addition to URLs
Summary: store and present repository labels in addition to URLs
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P2 normal (vote)
Target Milestone: 0.7   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 153599 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-07-18 12:01 EDT by Eugene Kuleshov CLA
Modified: 2006-09-15 21:25 EDT (History)
0 users

See Also:


Attachments
mylar/context/zip (1.37 KB, application/octet-stream)
2006-08-25 17:32 EDT, Mik Kersten CLA
no flags Details
mylar/context/zip (10.81 KB, application/octet-stream)
2006-09-06 19:40 EDT, Robert Elves CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2006-07-18 12:01:56 EDT
Repository label is not saved for Bugzilla and Jira, so I could not use custom label there.
Comment 1 Mik Kersten CLA 2006-08-03 02:10:31 EDT
From: bug 145123
> Patch applied.  I had to do a manual merge on AbstarctRepositorySettingsPage
> so you may want to verify.

The only think I noticed is this part:

  String repositoryLabel = repository.getRepositoryLabel();
  if (repositoryLabel != null && repositoryLabel.length() > 0) {
      repositoryLabelCombo.setText(repositoryLabel);
  }

Code you committed is accessing label using getPropertyMethod() and adding element to the Combo instead of setting text.
Comment 2 Mik Kersten CLA 2006-08-25 15:22:58 EDT
*** Bug 153599 has been marked as a duplicate of this bug. ***
Comment 3 Mik Kersten CLA 2006-08-25 17:32:52 EDT
We need to make Labels more consistent--currently they do not surface properly in the UI.  For the time being to avoid confusion I have changed "Label/template" to "Template" on the repository settings page.
Comment 4 Mik Kersten CLA 2006-08-25 17:32:53 EDT
Created attachment 48787 [details]
mylar/context/zip
Comment 5 Eugene Kuleshov CLA 2006-08-25 18:49:36 EDT
Mik, I really missing ability to define labels and see them on repository selection dialogs. Those web links are quite difficult to tell apart from each other...
Comment 6 Mik Kersten CLA 2006-08-25 19:15:59 EDT
Yes, let's use this bug report to fix that...
Comment 7 Eugene Kuleshov CLA 2006-08-25 19:31:06 EDT
By the way, I still think it provider icons should be shown on repository instances... along with those labels.
Comment 8 Mik Kersten CLA 2006-08-25 20:47:58 EDT
Yes, we just had that same discussion, and we'll probably make them bottom-right-hand-corner overlays since there is plenty of room.  Hard for icons like Bugzilla but I'll give it another whirl.
Comment 9 Robert Elves CLA 2006-09-06 12:38:02 EDT
Shall we go with an additional 'label' field in the Task Repository Settings page? Mixing the label and template selection field may be over complicated.
In the Task Repositories View my first thought is  that we present the respective repository icon (with 'blue bin' overlay) followed by the user provided label and make the actual url available via the mouse over tooltip.  Thoughts?
Comment 10 Eugene Kuleshov CLA 2006-09-06 12:51:10 EDT
We could move template selection into the url field.

As of label, I don't think it is necessary to show the url if label is not empty. If user want to see url he can just put it into the label.
Comment 11 Robert Elves CLA 2006-09-06 19:40:15 EDT
Update: TaskRepository view shows branding icon followed by label (if label doesn't exist it displays the url).
Templates can be selected from server combo which replaces the url with template.url and the label with template.label.
Comment 12 Robert Elves CLA 2006-09-06 19:40:50 EDT
Created attachment 49572 [details]
mylar/context/zip
Comment 13 Steffen Pingel CLA 2006-09-08 10:24:48 EDT
I think the old task repositories view that did not have columns looked a lot better and was "more intuitive" as it somewhat resembled the CVS/SVN repositories view.

I noticed that repositories do not have labels anymore when using wizards that require repository selection such as the new query wizard.
Comment 14 Mik Kersten CLA 2006-09-15 21:13:15 EDT
I agree with Steffen--we're not getting that much out of the columns and they do add substantial visual complexity.  Also, getting rid of the column will make it easier for this to become a common navigator view if needed.

Rob: if you get rid of the additional column the default label provider on the tree will do the right thing and show the label if there is one.
Comment 15 Robert Elves CLA 2006-09-15 21:25:34 EDT
Fixed.