Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 149999 - Use ComboFieldEditor from JFace
Summary: Use ComboFieldEditor from JFace
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-07 11:31 EDT by Michael Valenta CLA
Modified: 2006-08-02 14:39 EDT (History)
0 users

See Also:

Attachments
Patch (7.51 KB, patch)
2006-07-07 11:34 EDT, Michael Valenta CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2006-07-07 11:31:26 EDT 
I have released the ComboFieldEditor to JFace. I will attach a patch that
updates search to use this new class. The testing I did did not reveal any
problems but please have a look to ensure that I didn't miss something.
Comment 1 Michael Valenta CLA 2006-07-07 11:34:40 EDT 
Created attachment 45930 [details]
Patch

Actually, I was unable to test this for JDT Debug because I couldn't figure out how to get the code to be run (i.e. I created a Remote Launch Config but it didn't cause the code to get hit). The code is similar to what was in Debug except that getNumberOfControls was changed to return 2 instead of 1 (since there are two controls).
Comment 2 Darin Wright CLA 2006-07-10 12:39:07 EDT 
Will apply after next integration build.
Comment 3 Michael Rennie CLA 2006-07-18 16:04:13 EDT 
applied patch, and made a few additional changes.

please verify Darin W.
Comment 4 Darin Swanson CLA 2006-07-21 17:00:51 EDT 
Note that there is still a debug ComboFieldEditor in the J9 plugin
Comment 5 Darin Wright CLA 2006-08-02 14:39:50 EDT 
Verified. The J9 launching plug-in can migrate at a later time.