Community
Participate
Working Groups
Eclipse 3.2 lets me select new plugins to install, but then reports 0 kB free disk space (although there is plenty of it) and does not let me finish the installation. Strangely, when the new plugin's size is reported as unknown, it also shows 0kB but lets me finish anyway.
I believe I've raised a duplicate of this under bug 149610, though that is for Windows x64.
we do not support vista with this release. We have no copies of vista to play with and test, but if you have one and you are willing to help us check the patch for bug 142815 (this is for 2003) and see if you can create patch along those lines. Also, did you check new nightly builds? They have that patch applied already.
what's ETA on this one?
*** Bug 158064 has been marked as a duplicate of this bug. ***
Will this be fixed in 3.2.2?
Created attachment 54811 [details] Fix Here is a recommended fix. Previously, the code would only work if it recognized the Windows version number. This was done originally to handle Windows 95 or older, which we no longer support. The problem is, it requires updating for every new windows release. This patch removes that test entirely, so the win32 function is always called. This has the same result: UNKNOWN will be returned if the function failed, but we won't have to keep updating this code for every new windows release. I have also included in the patch the make/setup files I used to compile it. Feel free to include these or not, but I wanted to put them in the patch so I would have a record of them.
Created attachment 54812 [details] New DLL Here is the new update.dll built on the patch in the previous comment.
Branko/Dejan: please consider for 3.2.2 and 3.3. Without this fix there will be problems running update on Vista.
Created attachment 54813 [details] New update plugin For Vista users on the CC list: here is a new version of the org.eclipse.update.core.win32 plugin that contains this fix. I have tested on Vista and Win2K, but verification/testing from others would be appreciated.
Hey John, if I recall, there was an issue in update ui if the file size was still unknown, it wouldn't be possible to install features. Am I crazy? Anyone know this off the top of their head before I start digging?
zx: I don't know, I didn't look at update UI. The attached fix just stops it from returning "UNKNOWN" when it encounters an operating system version it doesn't recognize. Instead, it just calls the win32 function, and if the function fails then it returns UNKNOWN. With this fix, it should never return UNKNOWN on Vista. It seems like there is room for improvement at the UI level too - if the disk space is UNKNOWN, it feels like it should not prevent the user from proceeding. Feel free to dig...
(In reply to comment #6) > Windows 95 or older, which we no longer support. The problem is, it requires > updating for every new windows release. > This patch removes that test entirely, so the win32 function is always called. > This has the same result: UNKNOWN will be returned if the function failed John, if I understand you correctly, you have REMOVED the useful function with the bathwater. On Windows 2000/XP, the DLL will correctly compute the available space. With your patch, we will not be able to see the available space on any version of Windows? Is there a way to have a future-proof fix that does not affect the current function? We do have Vista machines now and I would much rather see this DLL return the actual available space rather than give up and return UNKNOWN.
Sorry, I guess I didn't explain it very well. The old code was: if (this is a version of windows I know about) { Call GetDiskFreeSpaceEx return disk free size } else { return UNKNOWN; } The new code is: Call GetDiskFreeSpaceEx if (success) return disk free size else return UNKNOWN This will return the free disk space for all versions of Windows, unless GetDiskFreeSpaceEx fails. I.e., this solution is future proof. I have tested on Win2K and Vista and it returns the correct free disk space on both. It looks like the original intent of the code was to guard against failure on Windows 95, but since we no longer support Windows 95 it is no longer necessary.
Ah... Sorry for doubting you :-). I agree this is the way to go. Branko, can you release John's patch?
*** Bug 160974 has been marked as a duplicate of this bug. ***
Adding McQ to CC as PMC representative for approval for fix into 3.2 maintenance stream.
+1.
Increasing severity - Vista support is very important for 3.2.2.
There is some confusion here regarding Vista. I have just downloaded 3.2.2 build that does not contain this patch and was able to install Callisto features on our Vista machine. We can still release this for other Windows dialects but Vista is covered as-is. I am lowering severity because I can install on Vista.
Branko, this patch is ready to go for 3.2.2 - please release.
Also include in HEAD and version/release for 3.3 M4.
To clarify the failing Vista case: If the feature has required space of "Unknown" you are allowed to continue with the installation. This is the case for most Callisto components. However, if the feature has a known non-zero required space, you cannot install it on Vista (or at least it doesn't work for me). For example, see the subclipse update site: http://subclipse.tigris.org/update_1.0.x/
Sorry, returning the severity to 'critical'. We have released this into M4 today and will be releasing into 3.2.2 soon.
released in both 3.2.x and 3.3
Verified in M20070112-1200, Vista Enterprise
