Community
Participate
Working Groups
Provide an implementation of a TracRepositoryConnector class and a TracRepositorySettingsPage for adding of Trac TaskRepository instances.
Steffen, please mark the bugs that you plan on getting to this week as P1 or P2.
Created attachment 45642 [details] The Trac connector and settings page implementation and test cases. This patch depends on the rename patch of bug 147816 (AllTracTests.java will probably conflict).
Created attachment 45643 [details] mylar/context/zip
Patch applied. - testGetTicketInvalidId fails, other tests pass - use ArrayList and not Vector unless you're after synchronization, and even then you may be better wrapping in a synchronized list - I didn't see a connector show up (no extenstion declared), will check other patches
All tests cases ran successfully on my system. Could you paste the stack trace (or error)? The XML-RPC library requires either Vector objects or arrays. I guess the goal is to maintain compatibility with early JDKs which don't have the List interface (and ArrayList class). Sorry, the extension delcaration is missing, I'll add a patch to bug 149385.
Created attachment 45831 [details] Fixes an exception when the last item in the access type combo is selected
Currently there is no notification when properties of a TaskRepository change. Prior to Mylar 0.5.3 TaskRepository objects were removed and readded from the tasklist, so notifications were sent through ITaskRepositoryListener. I think this may cause JiraServerFacade to cache stale JiraServer objects. This also applies to TracClientManager. I think a repositorySettingsChanged() method should be added to ITaskRepositoryListener. Mik, the patches haven't shown up in cvs, yet. Could you check if your commit was successful?
I neglected to actually do the commit, done now. Looking into the notification problem...
Guys, what was the reason for making AbstractAddExistingTaskWizard abstract? At least Jira and Web connectors are using the same empty subclass.
Created attachment 45850 [details] Fixes exception in TracRepositorySettingsPage and disables caching of ITracClient objects The patch fixes an exception when the last item in the access type combo is selected and disables caching of client objects in TracClientManager. Once notifications have been implemented this can be enabled again. The patch includes a test case which triggers the bug.
Created attachment 45858 [details] repository icon
Regarding comment#9: done, it's now CommonAddExistingTaskWizard and clients cna override getAddExistingTaskWizard but don't need to implement it (method is no longer abstract).
Patch and icon committed. Steffen, it looks like we're done here?
Yes, this report can be closed. What about notifications for changes to task repository properties? Should I open another report for that?
Yes, go ahead and open a new report. I have added a sandbox/site.xml to the standard dev update site in org.eclipse.mylar-site, and configured it to get the xmlrpc plug-in from your update site. I think that the dev update site is the most natural place for sandbox items. You can try installing it by pointing your update manager at the dev update site. Note that this means that your version numbers will now be synched with the rest of Mylar. Until the xmlrpc plug-in is merged you must let me know when it needs to be updated. If you get the queries going I think we can encourage people on the dev list to try this for tomorrow's build, and if you keep moving at this rate we may be able to distribute the Trac connector with 0.6.1.
Done. Nice work Steffen.
