Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 147766 - ID conflicts between widgets cause a failure
Summary: ID conflicts between widgets cause a failure
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: amehrega CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-19 14:39 EDT by amehrega CLA
Modified: 2016-05-05 11:06 EDT (History)
3 users (show)

See Also:


Attachments
patch (32.16 KB, patch)
2006-06-19 15:53 EDT, amehrega CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description amehrega CLA 2006-06-19 14:39:26 EDT
In some cases there are ID conflicts between trees or other containers because of the properties used to identify the tree data item.
Example: selecting a project when a test launch configuration is selected

I need to further investigate to see if this should be resolved during playback (e.g. by returning all matches) or leave it up to the user to do the proper widget registration.
Comment 1 amehrega CLA 2006-06-19 15:53:30 EDT
Created attachment 44862 [details]
patch

Needs to be more extensively tested.
Comment 2 amehrega CLA 2006-06-28 18:18:27 EDT
The fix for this was merged with the series of other fixes that will be going in.  The code will be checked in when 4.3 opens (July 10th).
Comment 3 amehrega CLA 2006-07-10 10:50:49 EDT
Fix checked into CVS.  Changes were restricted to a technology preview item.
Comment 4 Paul Slauenwhite CLA 2006-11-16 09:00:57 EST
ACTION: Please verify/close this defect.
Comment 5 Paul Slauenwhite CLA 2007-06-02 14:50:40 EDT
Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release.  Thanks.
Comment 6 DuWayne Morris CLA 2007-06-05 10:11:18 EDT
Verified.
Comment 7 DuWayne Morris CLA 2007-06-05 10:11:35 EDT
Closing.
Comment 8 Alexander Nyßen CLA 2008-01-31 00:16:51 EST
This bug has to be reopened, as it is not a valid solution. Consider the build.properties editor as an example. If checking an item of the SourceBuild-Tree (of the Build page) during recording, the respectively named item in the BinaryBuild-Tree is selected during playback, as the command is played for the first match only. Playing it for all matches would also not be legal, as this would check both items during playback, even if only one was be checked during recording.

A legal workaround would in my eyes be to ensure that ids are unique. This could be achieved by detecting dersolving unambiguities already during resolving (i.e. while recording) and by making the ids unique in such a case (e.g. by introducing an index to denote the proper match).

The patch/revision of AGR uploaded to bug #133099 addresses this issue by reporting an unambiguity to the user during playback, so he can report the problem.
Comment 9 Paul Slauenwhite CLA 2008-02-05 08:54:46 EST
(In reply to comment #8)
> This bug has to be reopened, as it is not a valid solution. Consider the
> build.properties editor as an example. If checking an item of the
> SourceBuild-Tree (of the Build page) during recording, the respectively named
> item in the BinaryBuild-Tree is selected during playback, as the command is
> played for the first match only. Playing it for all matches would also not be
> legal, as this would check both items during playback, even if only one was be
> checked during recording.
> 
> A legal workaround would in my eyes be to ensure that ids are unique. This
> could be achieved by detecting dersolving unambiguities already during
> resolving (i.e. while recording) and by making the ids unique in such a case
> (e.g. by introducing an index to denote the proper match).
> 
> The patch/revision of AGR uploaded to bug #133099 addresses this issue by
> reporting an unambiguity to the user during playback, so he can report the
> problem.
> 

As Alexander states, this defect has not been fixed in the current code.  However, since the AGR was moved from a Technology Preview component to an As-Is component in TPTP 4.5 and As-Is components are primarily provided for prior users but imply no support (for example, defects, news group, and mailing lists) or commitment to triage or resolve opened defects, reopening and changing the resolution to WONTFIX.   For this defect to be considered, please re-open with an attached patch including code to resolve the symptom and test cases to test the fix.