Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 147609 - make AbstractRepositoryConnector.canCreate*Task() a task repository capability
Summary: make AbstractRepositoryConnector.canCreate*Task() a task repository capability
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-17 08:35 EDT by Steffen Pingel CLA
Modified: 2006-08-02 04:11 EDT (History)
1 user (show)

See Also:

Attachments
Adds a repository parameter to canCreate*() methods (20.71 KB, patch)
2006-07-30 15:14 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylar/context/zip (11.45 KB, application/octet-stream)
2006-07-30 15:14 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2006-06-17 08:35:38 EDT 
Currently canCreateTaskFromKey() and canCreateNewTask() is invoked per connector and not per repository. If an instance of TaskRepository was passed to these methods task repositories that do not support these operations could be excluded from the list displayed by the "Add Existing Repository Task" and "New Repository Task" wizards. 

This was originally discussed in bug 146334.
Comment 1 Mik Kersten CLA 2006-06-19 21:37:27 EDT 
Fixed.
Comment 2 Mik Kersten CLA 2006-06-19 21:40:08 EDT 
Not fixed (wrong report).  Steffen, do you want to create a patch for this?  Also, please create a new report as I mentioned on my last comment on bug 146334 so that you can start providing patches for your connector.
Comment 3 Steffen Pingel CLA 2006-06-19 21:47:02 EDT 
I was just checking the cvs to see how this report was fixed :). I'll look into creating a patch.
Comment 4 Steffen Pingel CLA 2006-07-30 15:14:02 EDT 
Created attachment 47030 [details]
Adds a repository parameter to canCreate*() methods

Each connector is queried for the capability of each of its task repositories before the list of repositories is displayed in the wizard.
Comment 5 Steffen Pingel CLA 2006-07-30 15:14:09 EDT 
Created attachment 47031 [details]
mylar/context/zip
Comment 6 Mik Kersten CLA 2006-08-02 04:11:06 EDT 
Patch applied.  At some point we may need to look at separating the capability of connectors to create new tasks, and their ability to do so for a particular repository, since these are now conflated.