Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 147540 - Allow MultiRepositoryAwareWizard to finish on first page
Summary: Allow MultiRepositoryAwareWizard to finish on first page
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-16 18:39 EDT by Eugene Kuleshov CLA
Modified: 2007-02-28 11:10 EST (History)
2 users (show)

See Also:

Attachments
allows to finish on first page (15.60 KB, text/plain)
2007-02-18 21:13 EST, Steffen Pingel CLA 		no flags Details
mylar/context/zip (13.19 KB, application/octet-stream)
2007-02-18 21:13 EST, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2006-06-16 18:39:12 EDT 
Currently MultiRepositoryAwareWizard and its derivatives (e.g. wizard used to create new task) does not allow to finish right after selecting repository from the list on first page. Some custom wizards may don't have any additional pages and need to finish on the first page.
Comment 1 Mik Kersten CLA 2006-07-04 18:35:27 EDT 
I updated the wizard to provide instructions on the second page.  I think that for the time being these instructions are valuable, this seems like the best place to put them, and it's easy enough to hit Enter after selecting the first repository, so I think we should leave it for now.
Comment 2 Steffen Pingel CLA 2007-02-18 10:55:24 EST 
This feature would be nice for creating Trac tasks. Currently a meaningless wizard page is displayed before the editor is opened. You can assign this to me if you like.
Comment 3 Steffen Pingel CLA 2007-02-18 21:13:18 EST 
Created attachment 59243 [details]
allows to finish on first page

Here is a patch but it comes with the cost of constructing the nested wizard when a repository is selected instead doing it when the next button is clicked. The patch also provides a generic NewTaskWizard for connectors that do not require a second wizard page. 

I am not sure if the additional overhead justifies the convenience of saving a click. 

The generic wizard could be merged separately from the patch.
Comment 4 Steffen Pingel CLA 2007-02-18 21:13:21 EST 
Created attachment 59244 [details]
mylar/context/zip
Comment 5 Mik Kersten CLA 2007-02-19 13:42:11 EST 
Rob: please review.
Comment 6 Robert Elves CLA 2007-02-19 15:57:22 EST 
Looks good. Patch applied. I'll look into using initializeTaskData from the bugzilla wizard.
Comment 7 Steffen Pingel CLA 2007-02-28 11:10:58 EST 
Resolved. Task data initialization is addressed in bug 174993 .