Community
Participate
Working Groups
Let's use this report to collect them. Here is one: - (https://bugs.eclipse.org/bugs/show_bug.cgi?id=140512):
- full hyperlinks to bugs should open the corresponding task by checking the URL with the repository connector - comment#1 style links should be hyperlinked to open up comments
- URL hyperlinks should open the browser via TaskUiUtil (it will get the location bar and buttons that way). This will probably require a custom URL detector
Created attachment 45727 [details] mylar/context/zip Re comment#2, now opening using TaskUiUtil via custom TaskEditorUrlDetector/TaskEditorUrlHyperlink
Standard hyperlinks should not break after a dash, e.g. http://foo.bar/foo-bar
Committed fix for: - (https://bugs.eclipse.org/bugs/show_bug.cgi?id=140512): http://foo.bar/foo-bar
Please make task 123 work just like bug 123, including variants (e.g. task#123).
Committed support for task hyperlinks as Mik suggested in comment#6.
Links can also point to comments in other reports: bug 150165 comment #1.
Todo: - comment hyperlinking within an editor like comment#7 - bug/comment hyperlinking like bug# 146964 comment#8
http://wiki.eclipse.org/index.php/FAQ_How_do_I_hook_my_editor_to_the_Back_and_Forward_buttons%3F
This is an on-going report that we will use to continue collecting and correcting hyperlink nits.
As per task#154878 comment#6, task hyperlinks should have the task description as a tooltip if in the tasklist.
Rob: to support JIRA, could you make "issue 123" work in addition to "task 123"? We might pull this out into an extension point that connectors can specify...
Mik, with Jira people usually don't use "issue ID", because ID pattern is obvious enough on its own, but you'll need list of projects names/ids for linked Jira server...
Hyperlink detectors are contributed via the org.eclipse.mylar.tasks.ui.editors (hyperlinkDetector) extension point. Perhaps we could add an attributes element similar to the Repository Templates extension point that has text entries which could be used by RepositoryTextScanner for highlighting the hyperlinks rather then them being hard coded.
(In reply to comment #15) > Hyperlink detectors are contributed via the org.eclipse.mylar.tasks.ui.editors > (hyperlinkDetector) extension point. Perhaps we could add an attributes element > similar to the Repository Templates extension point that has text entries which > could be used by RepositoryTextScanner for highlighting the hyperlinks rather > then them being hard coded. Not sure how it will work, but these entries should be configured per repository. Also note that two Jira servers could use the same project names/ids, but we need to link to the specific one.
I'm not sure I understand the need to be 'per repository'? Are you thinking of the case of hyperlink detection outside the realm of the editor (where specific task/repository is known)?
(In reply to comment #17) > I'm not sure I understand the need to be 'per repository'? Are you thinking of > the case of hyperlink detection outside the realm of the editor (where specific > task/repository is known)? I thought it would make sense to reuse these detectors for other Eclipse editors, as well as for Team Sync and History view, e.g. open corresponding report and show hyperlinks in the commit comments. The latter one would require hyperlinking support from platform, byt we should have framework that can handle that. Since projects ready linked to the issue repositories...
Another variant of issue mentioned in comment#10 http://mail-archives.apache.org/mod_mbox//maven-dev/200607.mbox/%3c002f01c6a1d3$00ac96c0$6700a8c0@beatmik%3e
The whole following text is hyperlinked. I think it should be only the class:line in the brackets that get the hyperlink. bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla JiraWebIssueService$2.execute(JiraWebIssueService.java:105):
Linking for bug#<num> comment#<num> being addressed by bug#164221
Btw, for me the text in comment#20 is correctly hyperlinked (i.e. "bla bla..." is not hyperlinked).
(In reply to comment #22) > Btw, for me the text in comment#20 is correctly hyperlinked (i.e. "bla bla..." > is not hyperlinked). It is not marked as hyperlinked, but hyperlink is there. You can click on it...
(In reply to comment #23) > It is not marked as hyperlinked, but hyperlink is there. You can click on it... Oops, my mistake, that is the behavior that I am seeing.
"seems like you need to handle #XXXX patterns as bug hyperlinks too"
Rob: consider moving whatever is still open to the UI nits page, since it is hard to track what has and hasn't been implemented via comments.
(In reply to comment #26) > Rob: consider moving whatever is still open to the UI nits page, since it is > hard to track what has and hasn't been implemented via comments. Done.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=166733#c13 should link to comment but currently only opens bug report. ref: bug#194474
Hyperlink coloring can be incorrect until the hyperlink is hovered over, at which point, the coloring is removed entirely. i.e. (bug #24) for testing :-)
Created attachment 88471 [details] screenshot (In reply to comment #29) > Hyperlink coloring can be incorrect until the hyperlink is hovered over, at > which point, the coloring is removed entirely. > > i.e. (bug #24) for testing :-) Note that this seems to only happen in the description.
Created attachment 143247 [details] false positive A false positive observed on bug 262515, comment 8. A part of the comment is not actually a bug link, but is recognized as one.
Thanks Tomasz, I have created bug 285941 to track the problem. I am closing this bug since the implementation has changed significantly in recent releases which addresses the problems listed on this bug. Please file separate reports for any other bugs.
