Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 143546 - Provide a way to organize 'create' menu items into feature submenus
Summary: Provide a way to organize 'create' menu items into feature submenus
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Kenn Hussey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 160684
  Show dependency tree
 
Reported: 2006-05-24 13:31 EDT by Kenn Hussey CLA
Modified: 2008-01-28 16:39 EST (History)
1 user (show)

See Also:

Attachments
proposed changes (139.47 KB, patch)
2007-03-20 13:59 EDT, Kenn Hussey CLA 		no flags Details | Diff
oops forgot these changes (4.00 KB, patch)
2007-03-20 14:38 EDT, Kenn Hussey CLA 		no flags Details | Diff
Reviewed patch (220.79 KB, patch)
2007-03-22 01:12 EDT, Dave Steinberg CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenn Hussey CLA 2006-05-24 13:31:55 EDT 
Please provide a generator option or other means by which create child/sibling menu items can be organized into submenus (based on feature name) if so desired. Currently, for models with many types and containment features, users must often scroll to menu to find the desired item. Also, it can be confusing if the name of the feature is the same as the type of the child/sibling (e.g. imagine a containment feature named 'foo' and a type named 'Foo' - will result in 'Create Child > Foo Foo').
Comment 1 Kenn Hussey CLA 2007-03-20 13:59:56 EDT 
Created attachment 61432 [details]
proposed changes
Comment 2 Kenn Hussey CLA 2007-03-20 14:38:31 EDT 
Created attachment 61439 [details]
oops forgot these changes
Comment 3 Dave Steinberg CLA 2007-03-22 01:12:30 EDT 
Created attachment 61645 [details]
Reviewed patch

I've reviewed the patch. It mostly looked good, but I've made a few changes:

1. I updated it to patch against the changes from bug 178708.
2. I updated the Rose model.
3. I fixed a few picky things like hyphenating "sub-menu" in UI and comments, and adding space after commas.
4. I fixed the one error I found, a missing cast in the new depopulateManager() method when not using generics.
5. Since you felt compelled to fix the ID typo in the existing populateManager() Javadoc, I felt compelled to regen to pickup that change in all our editors.

So, now it looks all good to me. Any changes you'd like to discuss?
Comment 4 Dave Steinberg CLA 2007-03-22 11:56:14 EDT 
Kenn's enhancement is committed to CVS.
Comment 5 Kenn Hussey CLA 2007-03-22 16:10:48 EDT 
The changes are available in build I200703221305.
Comment 6 Nick Boldt CLA 2008-01-28 16:39:36 EST 
Move to verified as per bug 206558.