Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 143209 - HTMLAttributeValidator has reversed JSP-aware attribute name and value checks?
Summary: HTMLAttributeValidator has reversed JSP-aware attribute name and value checks?
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P2 normal with 1 vote (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
: 105875 160228 168607 175193 (view as bug list)
Depends on:
Blocks: 159926
  Show dependency tree
 
Reported: 2006-05-23 09:47 EDT by Nitin Dahyabhai CLA
Modified: 2007-02-22 18:26 EST (History)
5 users (show)

See Also:

Attachments
patch for HTMLAttributeValidator (1.37 KB, patch)
2006-05-23 09:48 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2006-05-23 09:47:04 EDT 
The code in org.eclipse.wst.html.core.internal.validate.HTMLAttributeValidator.validate(IndexedRegion) contains a couple of branches where it could report unknown names and attributes, but it will only do so on JSP regions.  Shouldn't it be reversed to report them as unknown names and values when it's *not* a JSP region?
Comment 1 Nitin Dahyabhai CLA 2006-05-23 09:48:00 EDT 
Created attachment 42261 [details]
patch for HTMLAttributeValidator

Current behavior for:
<body <%="dir" %>="left" alinks="">   -> Undefined attribute name (<%="dir" %>)
With patch:
<body <%="dir" %>="left" alinks="">   -> Undefined attribute name (alinks)
Comment 2 Nitin Dahyabhai CLA 2006-09-19 14:22:13 EDT 
Change applied to HEAD.
Comment 3 Amy Wu CLA 2006-10-05 15:17:25 EDT 
*** Bug 105875 has been marked as a duplicate of this bug. ***
Comment 4 Amy Wu CLA 2006-10-09 13:57:06 EDT 
*** Bug 160228 has been marked as a duplicate of this bug. ***
Comment 5 Nitin Dahyabhai CLA 2007-01-11 13:29:54 EST 
*** Bug 168607 has been marked as a duplicate of this bug. ***
Comment 6 Nitin Dahyabhai CLA 2007-02-15 03:11:37 EST 
Verified
Comment 7 Silas Christiansen CLA 2007-02-22 18:26:48 EST 
*** Bug 175193 has been marked as a duplicate of this bug. ***