Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 142266 - [implementation] Remove workaround for bug 137091
Summary: [implementation] Remove workaround for bug 137091
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.2 RC6   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-17 11:58 EDT by Dani Megert CLA
Modified: 2006-05-26 04:12 EDT (History)
5 users (show)

See Also:

Attachments
Fix (1.27 KB, patch)
2006-05-22 17:38 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-05-17 11:58:44 EDT 
R3.2 RC4

We added a workaround for bug 137091 which can be removed since bug 137091 got fixed for RC5.
Comment 1 Dani Megert CLA 2006-05-22 17:35:17 EDT 
The workaround worked while bug 137091 was in place but now that it got fixed for RC5 we see two new problems:
1) memory leak: last closed Java editor is leaked
2) after closing the last Java editor and then reopening a new one breaks the key
   binding

The fix is trivial: simply remove the workaround which got introduced for bug 137091.

Martin, Philippe and Mike please cast your vote.
Comment 2 Dani Megert CLA 2006-05-22 17:38:29 EDT 
Created attachment 42189 [details]
Fix
Comment 3 Martin Aeschlimann CLA 2006-05-23 04:01:07 EDT 
+1
Comment 4 Dani Megert CLA 2006-05-23 09:59:29 EDT 
arin, can you vote since Philippe is away?
Comment 5 Darin Wright CLA 2006-05-23 11:06:10 EDT 
+1
Comment 6 Mike Wilson CLA 2006-05-23 11:27:42 EDT 
+1
Comment 7 Dani Megert CLA 2006-05-23 11:55:37 EDT 
Fixed in HEAD.
Comment 8 Dani Megert CLA 2006-05-26 04:12:07 EDT 
Verified in I20060526-0010 that the code is in and that the scenarios reported in bug 137091 work (see bug 137091 comment 7 and bug 137091 comment 41).