Community
Participate
Working Groups
The current layout uses a combination of form sections with TextViewer objects (for displaying text with hyperlink detection and highlighting). We're using the fill horizontal layout which causes the text to wrap nicely when the editor is resized but it leaves excess space at the bottom of the form. One option may be to make the comments a default height and make them scrollable.
There is also excessive space under the comments, and the Description section should be collapsable. Both problems are manifest on bug 140473. I'm marking this P1 since we can't put out 0.5.2 with these layout problems. I don't think that making each comment a default height makes sense, because it will mean that we need to scroll mutliple times just to browse through a bug report. Any other ideas?
Given the fact that redraw error occasionally occur, I wonder if there is some inconsistency in the way that the size of the editor areas and comments is set.
Yes, it appears as thought the vertical size is originally calculated and drawn based on how the text would fall given the widthHint. When the editor is resized, the vertical height of the text is reduced but the composite holds onto the dead white space. If we get rid of the widthHint the text areas expand all the way out to the newline which isn't nice either.
So do you have any ideas beyond going back to fixed widths (which we will most likely need to do if the spacing issue doesn't get resolved)? I'm CC'ing Brock in case he has encountered this sort of form/viewer layout problem or has any ideas.
Also, "Expand All" has the wrong background. Instead of the text use the TaskListImages.EXPAND_ALL icon.
Does the Jira editor work as you expected? If so, I used a control listener to re-layout the entire page when the width changed (which can cause the height to cahnge as well). Making a collapsible section have a maximum size was really tricky. The client control will alway be its preferred size. If you wrap your text control in a composite and specify a height hint on the text control it works ok.
Still having problems with grabHorizontal/widthHint combination taking up extra space (when not using scrolling composite). Making description a fixed width for now.
*** Bug 167645 has been marked as a duplicate of this bug. ***
Created attachment 83834 [details] example patch to fix layout for editable descriptions
Created attachment 83835 [details] mylyn/context/zip
David Green has taken on further improvements.
