Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 142034 - XML error customization manager may ask for customization on incorrect elements
Summary: XML error customization manager may ask for customization on incorrect elements
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5 RC3   Edit
Assignee: Lawrence Mandel CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-16 13:15 EDT by Lawrence Mandel CLA
Modified: 2006-06-26 17:31 EDT (History)
1 user (show)

See Also:

Attachments
Patch that changes the scope of the error customization manager (4.42 KB, patch)
2006-05-16 13:23 EDT, Lawrence Mandel CLA 		no flags Details | Diff
Patch for the XML validation tests (4.86 KB, patch)
2006-05-16 14:07 EDT, Lawrence Mandel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Mandel CLA 2006-05-16 13:15:13 EDT 
The XML validator contains an error customization manager. This manager is extensible so anyone can contribute custom error messages. The manager under certain circumstances may request customizations for incorrect elements. (It also requests the customizations for the correct elements.) For example, in some cases when an error has been previously reported the manager will retain the error message information fooling it on later runs into requesting customization when there is no error.
Comment 1 Lawrence Mandel CLA 2006-05-16 13:16:51 EDT 
The fix for this problem is to change the scope of the error customization manager from the XML validator (of which there is a single instance in Eclipse) to the validation run (of which there are many).
Comment 2 Lawrence Mandel CLA 2006-05-16 13:23:13 EDT 
Created attachment 41609 [details]
Patch that changes the scope of the error customization manager

This patch corrects the problem reported by changing the scope of the error customization manager.
Comment 3 Lawrence Mandel CLA 2006-05-16 13:23:56 EDT 
Craig, although David is the default QA contact I've cced you for your review and approval as you're more familiar with this code.
Comment 4 Lawrence Mandel CLA 2006-05-16 14:07:39 EDT 
Created attachment 41618 [details]
Patch for the XML validation tests

This patch adds a test for this problem.
Comment 5 Lawrence Mandel CLA 2006-05-17 10:47:12 EDT 
Craig Salter approved this bug conditional on an announcement to wtp-dev announcing the breaking change of removing the global error customizer from the XML validator. This will only affect those extending the XML validator class.
Comment 6 Lawrence Mandel CLA 2006-05-17 11:35:09 EDT 
Changes released on 20060517.
Comment 7 Lawrence Mandel CLA 2006-06-26 17:31:07 EDT 
Verified with WTP 1.5 RC6.
Comment 8 Lawrence Mandel CLA 2006-06-26 17:31:17 EDT 
Closing bug.