Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 140551 - [junit] Strange ignored node in JUnit view
Summary: [junit] Strange ignored node in JUnit view
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC4   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-08 09:02 EDT by Dani Megert CLA
Modified: 2006-05-16 10:51 EDT (History)
4 users (show)

See Also:


Attachments
Patch (9.42 KB, patch)
2006-05-10 08:39 EDT, Markus Keller CLA
no flags Details | Diff
Preliminary image (961 bytes, image/gif)
2006-05-10 08:41 EDT, Markus Keller CLA
no flags Details
images from the UI designers (2.06 KB, application/zip)
2006-05-12 04:01 EDT, Martin Aeschlimann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-05-08 09:02:48 EDT
3.2 RC3

The ignored items in the JUnit view can't be opened. A dialog is shown. This is probably caused by the 'hacked' name.

This should be fixed for 3.2.
Comment 1 Martin Aeschlimann CLA 2006-05-09 05:17:52 EDT
I'll provide a patch.
We want also need to fix the hacked name to not show up like this in the list but to render it nicer.
Comment 2 Markus Keller CLA 2006-05-09 12:52:26 EDT
From bug 140758:
- Show number of ignored test count in header
Comment 3 Markus Keller CLA 2006-05-10 08:39:16 EDT
Created attachment 40926 [details]
Patch

needs image testignore.gif
Comment 4 Markus Keller CLA 2006-05-10 08:41:38 EDT
Created attachment 40927 [details]
Preliminary image

put this at org.eclipse.jdt.junit/icons/full/obj16/testignore.gif
Comment 5 Martin Aeschlimann CLA 2006-05-10 10:21:06 EDT
Patch looks good. Resulting functionalty and UI also reviewed with Erich.

The patch fixes the 'dirty' hack introduced in RC3 to use the name to keep the 'ignore' information but uses a new property.
- open test works also work for ignored test as we don't safe the strange name anymore
additionally as requested as JUnit 4 finish:
- number of ignored tests shown next to test count
- ignored test rendered with a new icon (UI designer request 2133 has been filed, waiting for result)

+1 for 3.2 RC4.
Comment 6 Martin Aeschlimann CLA 2006-05-10 10:51:44 EDT
Darin and Philippe, do you support this fix for 3.2 RC4?
Comment 7 Philipe Mulet CLA 2006-05-10 11:38:36 EDT
+1 for 3.2RC4
Comment 8 Darin Wright CLA 2006-05-10 11:56:01 EDT
+1
Comment 9 Martin Aeschlimann CLA 2006-05-11 06:51:55 EDT
not yet released, waiting for new image for UI design team
Comment 10 Martin Aeschlimann CLA 2006-05-11 12:17:31 EDT
patch released, should go into I20060511-1600
Comment 11 Johannes Rieken CLA 2006-05-12 03:33:41 EDT
verifying for I20060512-0010
Comment 12 Johannes Rieken CLA 2006-05-12 03:42:35 EDT
verified (1) number of ignored tests is shown, (2) ignored test have an icon (preliminary?) and their original name, (3) ignored test can be opened
Comment 13 Dani Megert CLA 2006-05-12 03:47:46 EDT
>(2) ignored test have an icon (preliminary?) and their original name,
Do you mean the '@'?
Comment 14 Martin Aeschlimann CLA 2006-05-12 04:01:15 EDT
Created attachment 41287 [details]
images from the UI designers

the released patch contains these images (they look similar than what I constructed in attachment 40927 [details], but are new from the UI designers).
Comment 15 Johannes Rieken CLA 2006-05-12 04:21:41 EDT
(In reply to comment #13)
> >(2) ignored test have an icon (preliminary?) and their original name,
> Do you mean the '@'?
> 

No, it was about the icon. It couldn't tell if its Markus icon in I20060511 or an UI-team designed icon.