Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 140125 - [junit] Polish JUnit view - was: JUnit view cannot handle @Ignore
Summary: [junit] Polish JUnit view - was: JUnit view cannot handle @Ignore
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 140502 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-05-04 05:19 EDT by Dani Megert CLA
Modified: 2006-05-11 03:49 EDT (History)
2 users (show)

See Also:

Attachments
Patch which adds JUnit version to view tool tip (5.06 KB, patch)
2006-05-04 19:05 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-05-04 05:19:35 EDT 
3.2 RC2

The JUnit view cannot handle @Ignore.
Comment 1 Dani Megert CLA 2006-05-04 05:21:49 EDT 
Let's use this bug for all the JUnit polishing.

Items so far:
- support @Ignore
- decouple layout from filtering
- capitalization of UI items
Comment 2 Dani Megert CLA 2006-05-04 19:05:11 EDT 
Created attachment 40442 [details]
Patch which adds JUnit version to view tool tip
Comment 3 Markus Keller CLA 2006-05-04 19:42:52 EDT 
Patch looks good, +1 for 3.2 RC3.
Comment 4 Dani Megert CLA 2006-05-04 19:44:59 EDT 
I've released the tooltip patch.
Comment 5 Dani Megert CLA 2006-05-05 12:22:09 EDT 
The JUnit view can now handle ignored tests, the progress goes to the end and the ignored tests are not flagged with a check mark and labelled "@Ignore: " + test name.

More support to come for RC4:
- decouple layout from filtering
- capitalization of UI items
- show ignored test count in header
- allow to filter for ignored tests
Comment 6 Sebastian Scheid CLA 2006-05-07 12:47:54 EDT 
*** Bug 140502 has been marked as a duplicate of this bug. ***
Comment 7 Sebastian Scheid CLA 2006-05-07 12:54:27 EDT 
"Run as->JUnit Plug-in Test" is not available but JUnit 4 Test Loader can be choosen in "Run...->JUnit Plug-in Test". Such a test run results in an "Exception: no runnable methods" in the JUnit view.
Comment 8 Martin Aeschlimann CLA 2006-05-09 05:48:40 EDT 
I filed bug 140758 for the remaining label issues that should go in RC4 and bug 140761 for decoupling filtering from presentation mode

Sebastian, your comment 7 seems unreleated. Can you file a new bug with the steps to reproduce?

I set this bug to RC3 so that the patch from comment can be verified.

Adding a filter for ignored tests should be addressed post 3.2.
Comment 9 Sebastian Scheid CLA 2006-05-09 07:23:58 EDT 
(In reply to comment #8)
> Sebastian, your comment 7 seems unreleated. Can you file a new bug with the
> steps to reproduce?

Sorry, for commenting here.

I found the problem: I did not include junit4 in the plugin dependencies (only in the build path). No need for a new report.
Comment 10 Johannes Rieken CLA 2006-05-11 03:26:03 EDT 
verifying for RC3
Comment 11 Johannes Rieken CLA 2006-05-11 03:44:10 EDT 
verified (1) @Ignore is shown, (2) version tooltip
Comment 12 Dani Megert CLA 2006-05-11 03:49:37 EDT 
.