Community
Participate
Working Groups
After updating from 3.2RC1 to 3.2RC2 I can not connect to the eclipse.org CVS using extssh method with proxy connection enabled (HTTP proxy type) (see the error dialog screen shot attached). I'm using one and the same workspace that works with CVS in RC1 and does not work with RC2. I also tried creating a new workspace and setting up the CVS connection there, and this failed as well.
Created attachment 40057 [details] error dialog screen shot
The only thing that changes between RC1 and RC2 is the version of the Jsch plugin we are using. If you go back to RC1, can you still connect (just to make sure it isn;t a connectivity problem at Eclipse.org)? You could also try copying the plugins/com.jcraft.jsch_0.1.26.jar from your RC1 install into your RC2 install (and move the 0.1.27 version elsewhere) and see if it works. Ymnk, is there anything that was changed in 0.1.27 that could have caused this behavior?
(In reply to comment #2) > The only thing that changes between RC1 and RC2 is the version of the Jsch > plugin we are using. If you go back to RC1, can you still connect (just to make > sure it isn;t a connectivity problem at Eclipse.org)? Yes, this always works if I open my workspace with RC1, but it always fails with RC2 > You could also try > copying the plugins/com.jcraft.jsch_0.1.26.jar from your RC1 install into your > RC2 install (and move the 0.1.27 version elsewhere) and see if it works. I tried the following: replaced the .27 with the .26, ran "eclipse -clean". After eclipse started it contained no CVS UI settings/information at all: Ther was no CVS perspective, ther was no "Team"->"CVS" preference page and its children, etc. Let me know if you need any additional information. Thanks, Mikhail
(In reply to comment #2) > Ymnk, is there anything that was changed in 0.1.27 that could have caused this behavior? 0.1.27 will check if http response code from http proxy is '200' or not. For example, my http-proxy(squid) is running on TCP port 3128 at 127.0.0.1, so... $ telnet 127.0.0.1 3128 Trying 127.0.0.1... Connected to localhost.localdomain (127.0.0.1). Escape character is '^]'. CONNECT dev.eclipse.org:22 HTTP/1.0 HTTP/1.0 200 Connection established SSH-1.99-OpenSSH_4.1 Mikhail, may I ask you to check what kind of code is returned?
I've made some additional hackery: I have replaced the com.jcraft.jsch_0.1.27 plugin with the .26 one as Michael suggested. I have renamed it to the .27 (renamed the .jar file and the bundle version in the manifest file) After I did that CVS became working. So, the problem seems to be in the com.jcraft.jsch plug-in. Mikhail
(In reply to comment #4) Hi Atsuhiko, > Mikhail, may I ask you to check what kind of code is returned? HTTP/1.0 200 Connection established SSH-1.99-OpenSSH_4.1 Thanks, Mikhail
Created attachment 40074 [details] This jar has fixed a bug, which appears in conneting to squid. (In reply to comment #6) > HTTP/1.0 200 Connection established > SSH-1.99-OpenSSH_4.1 Thank you for your testing. It seems the combination of RC2 and Apache's mod_proxy does not have such a problem, but by using squid I could reproduce that problem. I checked the code and found the bug and has fixed it. Please try it.
How safe is the fix? I need to seek approval for any new changes released to 3.2. This seems like an important issue (do you agree?). If the code change was trivial, I shouldn't have any problem getting it approved.
(In reply to comment #7) Hi Atsuhiko, > It seems the combination of RC2 and Apache's mod_proxy does not > have such a problem, but by using squid I could reproduce that problem. > I checked the code and found the bug and has fixed it. > Please try it. The new .28 plugin seems to work fine for me. Thanks, Mikhail
(In reply to comment #8) Hi Michael, > .. This seems like an important issue (do you agree?). I think it is really critycal to fix it, because this issue makes eclipse CVS extssh completely unusable for those seeting behind the proxy/firewal. The especially disappointing fact is that this functionality worked perfectly in the previous releases and milestones. Thanks, Mikhail
(In reply to comment #8) > How safe is the fix? I need to seek approval for any new changes released to > 3.2. This seems like an important issue (do you agree?). If the code change was > trivial, I shouldn't have any problem getting it approved. I think that fix is safe and trivial and that issue must be critical, so .28 should be used.
need to update Adrian about the version change, if we're putting it. note: we need to be done getting new versions soon.
Created attachment 40319 [details] jar generated from formal jsch 0.1.28 release
(In reply to comment #13) > Created an attachment (id=40319) [edit] > jar generated from formal jsch 0.1.28 release The attached jar works fine for me.
+1
+1 if adrian is happy
my god, don't ask for that! Adrian hasn't been happy since about 1983. ;-)
Adrian wasn't happy but said it was OK.
