Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 138825 - Update Manager site broken: underscores are in some feature version qualifiers
Summary: Update Manager site broken: underscores are in some feature version qualifiers
Status: CLOSED FIXED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: 3.10   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.10.0   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 89428
Blocks:
  Show dependency tree
 
Reported: 2006-04-27 00:08 EDT by David Williams CLA
Modified: 2018-06-29 15:20 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2006-04-27 00:08:17 EDT
As has been documented elsewhere, e.g. bug 89428, there is a bug in 3.1.2 code that prevents underscores being recognized in the feature qualifier field, in some, limited places in platform code.

At some point, we switched to use 
generateFeatureVersionSuffix 
which is the correct way to generate feature version IDs, but ... I'm guessing, 
will just end up being documented as a permanent limiation of 3.1.2. 

Hence, our 1.0.2 build does not work with 3.1.2 update manager. 

The other known area this effects is with "associated source" ... that should be double checked with 1.0.2 build.
Comment 1 David Williams CLA 2006-04-27 05:21:18 EDT
I have confirmed this "breaks" at least some source attachements in IDE (for those wanting to develop on top of WTP SDK). 

I will try a trial rebuild, ommitting the "generateVersionSuffix" directive, 
to confirm that is indeed the issue. 

Comment 2 Arthur Ryman CLA 2006-04-27 11:21:12 EDT
David, as we discussed on our telecon, developers have a workaround since they can get the source from CVS. The severity should be reduced, either to major or normal.
Comment 3 David Williams CLA 2006-04-27 11:42:34 EDT
I have confirmed that update manager will not work even for "runtime" (non-SDK) portions. So, I will leave as major "missing function" since we can not offer the community an update site for 1.0.2. I suggest that since the PMC has agreed to a 1.0.3 release, that we make our first 1.0.3 build simply a "fix" for this feature version issue (with no plugin changes), and populate 1.0.2 update site with that. 

Then, as Arthur mentioned, extenders can temporarily either use CVS or this same early 1.0.3 build if they need "source attachements" to work. 



Just to document it, following is the list of "luck of the draw" problematic features. This does not effect any plugins, (except the "source" ones, which same version as their feature). 

org.apache.axis.feature_1.2.1.v200602130710--0842282428442_
org.eclipse.jst.enterprise_ui.feature_1.0.2.v200604160300-pEBq_fMuyEaRNYx
org.eclipse.jst.web_ui.feature_1.0.2.v200604160100--2PD88P8HAM_TJU
org.eclipse.wst.common_core.feature_1.0.2.v200604160100--_OmSTOStcSZvm-
org.eclipse.wst.common_ui.feature_1.0.201.v200604160100--F7_hj6iFqqxjHR
org.eclipse.wst.server_ui.feature_1.0.2.v200604160100-PGIEUCSEN9K_M54
org.eclipse.wst.web_userdoc.feature_1.0.2.v200604160100--1G955G5A6C5AA_
org.eclipse.wst_1.0.2.v200604160100-f1b_-FNsJRLdbH1

org.eclipse.wst.common_core.feature.source_1.0.2.v200604160100--_OmSTOStcSZvm-
org.eclipse.jst.enterprise_ui.feature.source_1.0.2.v200604160300-pEBq_fMuyEaRNYx
org.eclipse.jst.web_ui.feature.source_1.0.2.v200604160100--2PD88P8HAM_TJU
org.eclipse.wst.server_ui.feature.source_1.0.2.v200604160100-PGIEUCSEN9K_M54
org.eclipse.wst.common_ui.feature.source_1.0.201.v200604160100--F7_hj6iFqqxjHR
Comment 4 David Williams CLA 2006-04-27 12:16:16 EDT
propose to fix as "the first thing" in 1.0.3 stream, leaving plugins (code) the same, but correcting the feature versions. This will require removing 
the generateSuffix directive (already done), and also "touching" the feature's cvs version numbers, just to make sure the new feature versions appear "newer" than the old feature versions. 

Comment 5 David Williams CLA 2006-05-01 00:02:40 EDT
Fixes have been tested and verified. 

To review, this was only a change to the exact build scripts, no code was touched. I changed so feature qualifier suffixes were not created automatically, to avoid the "random" generation of underscores. 

To avoid "resolution confusion", I also "touched" all the features definitions in CVS to be sure their date (and hence version qualifiers) would look more recent that their same qualifier, with the suffix. 

While this is, technically, only an issue with "update manager site", I think the zip distribution with these new feature version should be considered our "final" one for 1.0.2 (as well as our first for 1.0.3). 

Comment 6 Arthur Ryman CLA 2006-05-01 16:23:10 EDT
+1 for inclusion in 1.0.3

If you are confident that this just fixes the broken source attachments, then I am open to treating this one fix as a 1.0.2 Refresh, after you personally verify it and test it for regressions.
Comment 7 Tim Wagner CLA 2006-05-02 09:20:08 EDT
+1 (both 1.0.3 fix #1 and 1.0.2A ideas)
Comment 8 Tim Wagner CLA 2006-05-02 12:32:53 EDT
+1 for 1.0.3 inclusion
Comment 9 David Williams CLA 2006-05-02 15:09:40 EDT
I've fully checked the integrity of the new 1.0.2 build, currently at 

http://download.eclipse.org/webtools/committers/drops/R-1.0.2-200604280245/

The update manager site seems to work fine, I've ocnfirmed no plugin's changed. 
map files the same, except for featues, which is what we'd expect. 

I've asked Naci if/when he could produce some "all in one" zips that use these new zips, and asked Ted to double check the integrity, just to be extra safe. 
Comment 10 David Williams CLA 2006-05-06 01:10:46 EDT
just documenting bug relationships. 
Comment 11 John Lanuti CLA 2006-11-28 15:37:18 EST
This is part of a mass update to close out all stale WTP defects already verified by the reporter but awaiting closure by the assignee.  If you feel this defect was closed inappropriately, please reopen.

Thanks, John Lanuti