Community
Participate
Working Groups
The tool tips for icons in the tool bar should also display the key bindings of the actions. E.g. the tooltip [Step Into] should be [Step Into (F5)] cf. Preferences -> Keys(Experimental) : there is the icon and the binding
While the implementation would be done by me or Paul the decision is workbench-level so on to you Tod...
This is a great enhancement which I missed since the beginnging of my eclipse-tour. 1+ for this. Moffat and Paul: tell me if you don't have the time for this one, then i'll look into that and provide a patch
Another dup of bug 46469?
There are currently no plans to work on this although we would be happy to review a a patch.
My patch to bug 46469 added keybindings to tooltips in workbench toolbars. I've verified in I20070615-1200 that it also works in view toolbars (assigned a shortcut to JUnit's Rerun Test action). Moving to Debug to see why the tooltips don't appear in the Debug view initially. They do appear, however, when I close all instances of the Debug view and the reopen it.
*** Bug 120459 has been marked as a duplicate of this bug. ***
Investigate for 3.4.
When the debug view is opened for the first time, nothing is being debugged. The keybindings for resume/suspend/etc are only active in the "debugging" context. So when the view is opened and the tooltips computed, there is no active key binding. Tooltips are not recomputed unless the view is closed/reopened. If the view is opened when the debugging context is active, the keybindings may be active, resulting in tooltips with the keys. Don't know what debug can do about this, moving to platform UI for comment.
Created attachment 76685 [details] Fix The problem is that ExternalActionManager.CommandCallback.addPropertyChangeListener(..) silently throws away the previous listeners if the same command is registered more than once. This assumption makes little sense, since the same command can sensibly be bound to multiple actions. Fortunately, the fix is not a breaking API change, since it just fixes a previously undefined case.
Tested the patch. Works great. Tooltips update properly to show keybindings when debugging.
Does anything speak against a target milestone of 3.4 M3 for releasing the patch?
Released to HEAD >20070924 with a slight fix to CommandCallback#removePropertyChangeListener(*) PW
> with a slight fix to CommandCallback#removePropertyChangeListener(*) <blush> Sorry for this leak and thanks for the careful review!
In I20071030-0010 PW
