Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 136482 - great bug:Installation results to broken file associations
Summary: great bug:Installation results to broken file associations
Status: CLOSED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQL Editor Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Hui Cao CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-12 17:46 EDT by Vladyslav Kosulin CLA
Modified: 2006-10-26 23:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladyslav Kosulin CLA 2006-04-12 17:46:57 EDT
After installing wtp-sdk-R-1.0.2RC1-200604070459.zip to a fresh eclipse 3.2M6 with GEF 3.2M6, EMF 2.2.0, the following stops working:
Menu item Window/Preferences/General/Editors/File Associations
Try to choose any File type, and to push button "Add..." an associated editor. Nothing happens.
After I disable DTP SDK feature, it works fine.
Comment 1 John Graham CLA 2006-04-14 12:28:17 EDT
Should be logged against WTP, not DTP.
Comment 2 John Graham CLA 2006-04-14 12:28:34 EDT
WTP bug, not DTP
Comment 3 Vladyslav Kosulin CLA 2006-04-17 09:50:38 EDT
Well, as a matter of fact, this was dtp-sdk_0.9M6_N040706.zip, not wtp-sdk. My fault.
But I love John's idea of marking bug as invalid because it was created against a wrong component. This way many bugs can disappear in seconds.
Comment 4 Vladyslav Kosulin CLA 2006-04-17 10:39:55 EDT
The issue also applies to the new build dtp-sdk_0.9RC1_N041406.zip
Comment 5 John Graham CLA 2006-04-17 14:05:21 EDT
The bug was simply put into a state indicating its position relative to DTP. This lets you respond, as you have.

At any rate, I can not repro this with the 4/14 build of DTP. Here are my specifics:

DTP 0.9 4/14 SDK build
Eclipse 3.2M6
EMF 2.2M6
GEF 3.2M6
Windows XP SP2
Sun J2SE 1.4

Perhaps there is an environmental difference that accounts for the problem you're seeing?
Comment 6 Vladyslav Kosulin CLA 2006-04-17 14:38:28 EDT
The only difference I can confirm is in use of jre 1.5.0_06.

The error log does not show any dtp related components, but this happens only if I enable dtp feature. I tried this twice with fresh new installations of Eclipse and with 2 different dtp bundles with the same effect. i do not think the cause is in some file being just corrupted. Here is excerpt from the log:

!ENTRY org.eclipse.ui 4 4 2006-04-17 14:22:36.246
!MESSAGE Unhandled event loop exception

!ENTRY org.eclipse.ui 4 0 2006-04-17 14:22:36.246
!MESSAGE Unsupported or unrecognized format
!STACK 0
org.eclipse.swt.SWTException: Unsupported or unrecognized format
        at org.eclipse.swt.SWT.error(SWT.java:3374)
        at org.eclipse.swt.SWT.error(SWT.java:3297)
        at org.eclipse.swt.SWT.error(SWT.java:3268)
        at org.eclipse.swt.internal.image.FileFormat.load(FileFormat.java:73)
        at org.eclipse.swt.graphics.ImageLoader.load(ImageLoader.java:127)
        at org.eclipse.swt.graphics.ImageDataLoader.load(ImageDataLoader.java:18)
        at org.eclipse.swt.graphics.ImageData.<init>(ImageData.java:327)
        at org.eclipse.jface.resource.URLImageDescriptor.getImageData(URLImageDescriptor.java:57)
        at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:279)
        at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233)
        at org.eclipse.ui.internal.registry.EditorDescriptor.verifyImage(EditorDescriptor.java:303)
        at org.eclipse.ui.internal.registry.EditorDescriptor.getImageDescriptor(EditorDescriptor.java:285)
        at org.eclipse.ui.internal.dialogs.EditorSelectionDialog.getImages(EditorSelectionDialog.java:319)
        at org.eclipse.ui.internal.dialogs.EditorSelectionDialog.getInternalEditors(EditorSelectionDialog.java:333)
        at org.eclipse.ui.internal.dialogs.EditorSelectionDialog.fillEditorTable(EditorSelectionDialog.java:217)
        at org.eclipse.ui.internal.dialogs.EditorSelectionDialog.createDialogArea(EditorSelectionDialog.java:204)
        at org.eclipse.jface.dialogs.Dialog.createContents(Dialog.java:794)
        at org.eclipse.jface.window.Window.create(Window.java:426)
        at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1116)
        at org.eclipse.jface.window.Window.open(Window.java:785)
        at org.eclipse.ui.internal.dialogs.FileEditorsPreferencePage.promptForEditor(FileEditorsPreferencePage.java:515)
        at org.eclipse.ui.internal.dialogs.FileEditorsPreferencePage.handleEvent(FileEditorsPreferencePage.java:440)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3346)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2966)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
        at org.eclipse.jface.window.Window.open(Window.java:796)
        at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:65)
        at org.eclipse.jface.action.Action.runWithEvent(Action.java:499)
        at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:539)
        at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:488)
        at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:400)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3346)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2966)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1914)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1878)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
        at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
        at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:68)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:376)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:169)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
        at org.eclipse.core.launcher.Main.basicRun(Main.java:280)
        at org.eclipse.core.launcher.Main.run(Main.java:977)
        at org.eclipse.core.launcher.Main.main(Main.java:952)
Comment 7 John Graham CLA 2006-04-17 17:12:58 EDT
Interesting... I had to work backward from the stack trace to trigger this same sort of effect in my environment.

Turns out that DTP is indeed the culprit here, specifically the SQL editor. We'll get this fixed in a build for later this week, but, if you want to change it yourself, you can:
1. Unpack org.eclipse.datatools.sqltools.sqleditor_0.9.0.......jar
2. Edit the plugin.xml file for the following:
Find the <extension point="org.eclipse.ui.editors"> near the top of the file, and location the line:

icon=""

change that to

icon="icons/sql_editor.gif"

repack, and replace in your plugins folder. On restarting Eclipse, the problem should go away.
Comment 8 John Graham CLA 2006-04-17 17:15:06 EDT
Hui,
Let's get this fixed this week, and can we clean up that %rountine.editor entry? Also, why are there multiple SQL Dev entries in the file associations-->Add dialog?  Don't we have just one editor? If not, then let's distinguish them somehow by naming
Comment 9 Hui Cao CLA 2006-04-18 03:19:44 EDT
Hi Vladyslav, please verify. The missing icon name is filled in and the icon files are updated to be different with WTP. Now we have 3 types of editors that user can see from the "Editor Selection" dialog: SQL Editor, SQL File Editor and Routine Editor. SQL Editor and Routine Editor are not linked with any file extensions by default. If you install WTP, you'll see another SQL Editor. That's the reason why John saw multiple "SQL Dev" entries.
Comment 10 John Graham CLA 2006-04-18 09:27:52 EDT
This will appear in the next DTP 0.9 build, scheduled either for today (4/18) or tomorrow.
Comment 11 Vladyslav Kosulin CLA 2006-04-18 12:16:30 EDT
Solution from Comment #7 works. Thanks.
Comment 12 Vladyslav Kosulin CLA 2006-04-18 12:19:03 EDT
A note: instead of SQL File Editor I see SQL Source Editor.
Comment 13 Hui Cao CLA 2006-04-18 21:21:53 EDT
SQL Source Editor is from WTP RDB. Thanks!
Comment 14 Hui Cao CLA 2006-10-26 23:51:36 EDT
closed