Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 135731 - [Dialogs] Open resource dialog should honor Window Working sets
Summary: [Dialogs] Open resource dialog should honor Window Working sets
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 51427
  Show dependency tree
 
Reported: 2006-04-08 19:56 EDT by Matthew Conway CLA
Modified: 2006-12-12 08:44 EST (History)
5 users (show)

See Also:

Attachments
Fixes a problem when selected aggregate WS is empty (985 bytes, patch)
2006-11-29 06:06 EST, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Conway CLA 2006-04-08 19:56:49 EDT 
It somewhat defeats the purpose of having a window working set if everything responsible for opening files does not honor them.
Comment 1 Eric Moffatt CLA 2006-04-10 10:08:46 EDT 
Kim, you first...let me know if this should be in [Dialogs]...
Comment 2 Kim Horne CLA 2006-04-10 10:23:55 EDT 
yes, dialogs
Comment 3 Eric Moffatt CLA 2006-04-12 16:03:58 EDT 
Do you want me to reassign??
Comment 4 Susan McCourt CLA 2006-07-10 17:25:44 EDT 
moving Open Resource related bugs to Szymon.
Szymon, please move between you and Krystof as needed.  Let me know if you have any questions.  These are all the bugs I had related to OpenResource.
Comment 5 Szymon Brandys CLA 2006-10-23 06:29:29 EDT 
Resource dialog respects working sets now.
Committed for build >20061019
Comment 6 Paul Webster CLA 2006-10-31 13:27:09 EST 
I had eclipse open with org.eclipse.jface and org.eclipse.ui.workbench.  I used CTRL+SHIFT+R to search for ActionHandler ... it found one in each project.

Then I created a working set with only org.eclipse.jface and selected it.

When I do the same steps, the dialog still shows me but ActionHandler classes.

PW
Comment 7 Szymon Brandys CLA 2006-11-02 03:38:26 EST 
(In reply to comment #6)

Did you set the working set in the Navigator?
The dialog doesn't respect working sets from the navigator.
You have to set it in the dialog.

It works for me, so if you have still the problem
with it, please let me know.
Comment 8 Paul Webster CLA 2006-11-02 06:31:54 EST 
OK, but I created and selected my working set from the double-folder icon in the main toolbar.

I just tested it in I20061101-1200.  Steps:

1. I have no working sets, and platform-ui checked out
2. CTRL+SHIFT+R and then type ActionHandler

You should see 2, one in org.eclipse.jface and one in org.eclipse.ui.workbench

3. Use the modify workbench working sets to create one that only contains jface
4. select it

All of my projects in the package explorer disappear except jface

5. CTRL+SHIFT+R and then type ActionHandler

It still shows both classes in the dialog.

PW
Comment 9 Paul Webster CLA 2006-11-03 08:00:01 EST 
Kim, could you comment on this proposal?

PW
Comment 10 Szymon Brandys CLA 2006-11-03 08:06:00 EST 
(In reply to comment #8)

I will add 'Window Working Set' option to the resource dialog menu.
If it is selected, the dialog will use the window WS.
Actually, this is how it is solved in JDT's open type dialog.
Comment 11 Kim Horne CLA 2006-11-03 10:34:47 EST 
By default eclipse uses the window working set in all views that use the working set action APIs.  I would suggest that this dialog (as well as the open type dialog) do the same.
Comment 12 Szymon Brandys CLA 2006-11-29 06:06:01 EST 
Created attachment 54695 [details]
Fixes a problem when selected aggregate WS is empty 

The bug is solved in build >20061129, this patch fixes only one small issue.
Comment 13 Paul Webster CLA 2006-11-30 13:00:10 EST 
Released patch >20061130

PW
Comment 14 Szymon Brandys CLA 2006-12-01 08:36:44 EST 
Mark as FIXED