Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 133961 - Refactor URL application adapters.
Summary: Refactor URL application adapters.
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard: housecleaned460 closed471
Keywords:
: 222642 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-03-29 19:27 EST by Jeff Nevicosi CLA
Modified: 2016-05-05 11:08 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Nevicosi CLA 2006-03-29 19:27:03 EST
Mozilla & Firefox adapters are remarkably similar.  Duplicate code in these classes may eventually cause an update problem.

Refactor is needed.  Either create an abstract class, or extend the FirefoxAdapter from the MozillaAdapter.
Comment 1 Mark D Dunn CLA 2006-03-31 22:49:23 EST
Perhaps an abstract class would work.  When I originally developed these, I tried to extend the Firefox class from the Mozilla class, but it made it extremely confusing so I went with two classes.

You are welcome to give it a try and combine these.
Comment 2 Mark D Dunn CLA 2006-04-05 15:27:07 EDT
Set milestone to 4.3
Comment 3 Mark D Dunn CLA 2006-04-06 16:27:43 EDT
Accept bug.
Comment 4 Mark D Dunn CLA 2007-01-16 16:25:16 EST
Add estimate.  
Comment 5 Paul Slauenwhite CLA 2007-01-26 08:25:15 EST
Targeting to future since not containable in 4.4.
Comment 6 Paul Slauenwhite CLA 2007-01-26 08:59:12 EST
As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4.  All other Test Project defects have been targeted to future.

If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org).  We will collectively triage and assess our resources to determine a case-by-case decision. 
Comment 7 Paul Slauenwhite CLA 2007-01-26 09:00:50 EST
As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4.  All other Test Project defects have been targeted to future.

If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org).  We will collectively triage and assess our resources to determine a case-by-case decision. 
Comment 8 Paul Slauenwhite CLA 2007-01-26 09:03:09 EST
Correction:  The Test Project mailing list is tptp-testing-tools-dev@eclipse.org.
Comment 9 Paul Slauenwhite CLA 2009-06-09 14:45:55 EDT
*** Bug 222642 has been marked as a duplicate of this bug. ***
Comment 10 Paul Slauenwhite CLA 2009-06-09 14:46:08 EDT
[From https://bugs.eclipse.org/bugs/show_bug.cgi?id=222642]:

Move URL application adapters to new org.eclipse.tptp.test.recorders.url
plug-ins.

The following classes need to be moved to the new
org.eclipse.tptp.test.recorders.url plug-in
(org.eclipse.tptp.test.recorders.url.internal.application.adapters in the src
source tree):
org.eclipse.hyades.execution.recorder.local.appadapters.FirefoxAdapter.java
org.eclipse.hyades.execution.recorder.local.appadapters.FirefoxPrefs.java
org.eclipse.hyades.execution.recorder.local.appadapters.InternetExplorerAdapter.java
org.eclipse.hyades.execution.recorder.local.appadapters.JNIWrapper.java
org.eclipse.hyades.execution.recorder.local.appadapters.MozillaAdapter.java
org.eclipse.hyades.execution.recorder.local.appadapters.MozillaPrefs.java

Note: This was not done under enhancement 208110 since there are dependencies
on JNIWrapper and InternetExplorerAdapter in the following classes that
requires redesigning the URL Recorder for Windows/IE:

org.eclipse.hyades.internal.execution.recorder.local.RecorderDataProcessorHelper.java
org.eclipse.hyades.internal.execution.recorder.local.RecorderStopper.java
Comment 11 Paul Slauenwhite CLA 2009-06-30 06:58:50 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 12 Kathy Chan CLA 2010-11-18 23:08:30 EST
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.