Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 13002 - Internal error dialog focus default
Summary: Internal error dialog focus default
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 blocker (vote)
Target Milestone: 2.0 M5   Edit
Assignee: Eduardo Pereira CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 14668
Blocks:
  Show dependency tree
 
Reported: 2002-04-08 11:41 EDT by Jed Anderson CLA
Modified: 2002-05-14 11:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jed Anderson CLA 2002-04-08 11:41:09 EDT 
Build: 20020404

The internal error dialog defaults the focus to the "Yes" answer, it should
default to "No".

The main problem I have with defaulting to "Yes" is that an absentminded Enter
causes the entire workspace to shutdown.
Comment 1 Nick Edgar CLA 2002-04-08 12:52:54 EDT 
Agree.  Should fix for M5.
Comment 2 Eduardo Pereira CLA 2002-04-08 17:49:38 EDT 
It depends on the type of error.

If you get something like NullPointerException the default will be "NO" but if 
you get OutOfMemoryError, StackOverflowError, VirtualMachineError, SWTError it 
is very likely that you will have subsequent errors and you should exit.
Event the error message is different. In the second case it recomends that you 
exit and in the first case it just asks.

Going to mark this as invalid, if you agree.
Comment 3 Jed Anderson CLA 2002-04-08 18:16:11 EDT 
I have no problem changing the contents of the dialog.  Suggesting the user exit
on critical errors sounds like a good plan.

However, setting up defaults so that an absentminded Enter causes the workspace
to shutdown is not a feature.  Some of our users are seeing 20 minute startup.
(http://bugs.eclipse.org/bugs/show_bug.cgi?id=11585)  If they hit enter by
mistake we've just wasted 20 minutes of their life.

Forcing the user to click yes is a good thing in this case.
Comment 4 Nick Edgar CLA 2002-04-08 22:41:50 EDT 
I concur with Jed.
I feel it is wrong to change which button is the default based on the severity.
This is just asking for command mode errors since it works differently 
depending on something the user isn't even paying attention to.
Particularly since sometimes an SWTError can occur but is not a serious error.
There are other cues which could be used, e.g. big red flashing text, to 
indicate it's a severe error and the recommendation is to exit.
Comment 5 Eduardo Pereira CLA 2002-04-08 22:57:37 EDT 
Fixed and released.
Comment 6 John Wiegand CLA 2002-04-23 20:02:23 EDT 
0423

This still fails for me.
If I try to debug it, things work, but in normal operation,
the default appears to be yes.
Comment 7 Nick Edgar CLA 2002-04-24 16:51:45 EDT 
Must fix for Friday.
Comment 8 Eduardo Pereira CLA 2002-04-25 15:29:44 EDT 
I added code to InternalErrorDialog to work it around. Going to leave this bug 
opened so I can remove the workaround when bug 14668 gets fixed.
Comment 9 Eduardo Pereira CLA 2002-05-14 11:17:26 EDT 
If bug 14668 won't be fixed then we can't remove the workaround.
Marking this as fixed since the workaround is becoming the fix.