Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 129223 - Enable access to the GenModel's import manager from outside
Summary: Enable access to the GenModel's import manager from outside
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dave Steinberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 75925
Blocks:
  Show dependency tree
 
Reported: 2006-02-23 15:22 EST by Stephan Eberle CLA
Modified: 2008-01-28 16:46 EST (History)
2 users (show)

See Also:


Attachments
Enhancement suggestion (1.04 KB, patch)
2006-02-23 15:24 EST, Stephan Eberle CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Eberle CLA 2006-02-23 15:22:01 EST
It happend to me already a couple of times, that I needed to add my own extensions to the EMF code generator. As my intension is to generate Java files, I'd like to reuse the ImportManager implemented in GenBaseImpl. However, two very much decisive methods for that case, namely getImportManager() and setImportManager() are protected. So, the only option to reuse them, is to subclass the GenModel. But this has plenty of side effects and is somewhat complicated. It would be much more convenient if I could just aggregate the GenModel into my own generator extension and call the above named methods from outside. In a word, I'm wondering if these two methods could be made public.
Comment 1 Stephan Eberle CLA 2006-02-23 15:24:52 EST
Created attachment 35261 [details]
Enhancement suggestion
Comment 2 Ed Merks CLA 2006-02-23 15:37:16 EST
This sounds very reasonable.  We should probably provide public API methods on the GenModel interface for this, right?
Comment 3 Stephan Eberle CLA 2006-02-23 17:01:17 EST
(In reply to comment #2)

That would be just perfect!
Comment 4 Dave Steinberg CLA 2006-05-01 10:57:40 EDT
This enhancement was implemented as part of bug 75925 and has now been committed to CVS.
Comment 5 Nick Boldt CLA 2006-05-02 11:17:48 EDT
Fixed in 2.2.0RC2 (S200605020900)
Comment 6 Nick Boldt CLA 2008-01-28 16:46:23 EST
Move to verified as per bug 206558.