Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 128904 - New version for the eclipse tag in the plugin.xml
Summary: New version for the eclipse tag in the plugin.xml
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 128866
Blocks:
  Show dependency tree
 
Reported: 2006-02-21 17:33 EST by Pascal Rapicault CLA
Modified: 2006-02-27 14:18 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2006-02-21 17:33:28 EST
To solve the bug #128866, we are required to change the version of the plugin.xml file to be <?eclipse version="3.2"?> instead of <?eclipse version="3.0"?>.

This change is not implemented yet. When it will be some tweak will be required to PDE. Here is the list of things I can think of:
- when <?eclipse version="3.0"?> is used report warnings when an extension id contains "."
- when <?eclipse version="3.2"?> is used no warning is required when an extension id contains "."
- probably change the way PDE computes fully qualified names for extension / extension points to properly handles the eclipse version markup
- change the wizards to generate <?eclipse version="3.2"?> when the plug-in is for eclipse 3.2 and <?eclipse version="3.0"?> before that.
Comment 1 Wassim Melhem CLA 2006-02-24 23:53:03 EST
done.  PDE now generates and handles 3.2 processing instructions.

Incidentally, since anything seems to go as far as ID syntax goes, PDE is staying out of the warning business if an ID contains a dot.
Comment 2 Pascal Rapicault CLA 2006-02-25 10:20:14 EST
Are you doing any verification if the eclipse tag is set to 3.0?
Comment 3 Wassim Melhem CLA 2006-02-25 11:14:51 EST
not sure what you mean in comment 2.

verification of what?  that an ID does not contain a dot if the processing version is 3.0?  

If so, then as I said in comment 1, no.  PDE is staying out of that business since the runtime handles it fine.
Comment 4 Wassim Melhem CLA 2006-02-25 11:18:56 EST
actually we do it (and have always done it) for extension point IDs, but not for extension IDs.  

An extension ID syntax varies per extension point.  We don't validate it, since the schema for an extension point just says that it's a string.
Comment 5 Pascal Rapicault CLA 2006-02-27 08:59:06 EST
>An extension ID syntax varies per extension point.  We don't validate it, since
>the schema for an extension point just says that it's a string.
  The whole issue we encountered with M5 was caused by the fact that the extension ID is not just a string and is a simpleToken as defined in the plugin.dtd (see http://help.eclipse.org/help31/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/misc/plugin_manifest.html)
and that PDE use to be too permissive.

  ExtensionId := SimpleToken
  SimpleToken := sequence of characters from ('a-z','A-Z','0-9','_')
Comment 6 Wassim Melhem CLA 2006-02-27 10:31:20 EST
The plugin.dtd also says that it's optional, but the Core extension points (e.g. buiders, natures, products, ..) make it 'required' in their schemas.
So the plugin.dtd behaviour can be overridden evidently.

It is too late to legislate the use and syntax of this ID, particularly when the runtime tolerates both forms whether or not the processing instruction is 3.0 or 3.2.