128078 – [Commands] ObjectState enablement of actions broken for non IAdaptable objects

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 128078 - [Commands] ObjectState enablement of actions broken for non IAdaptable objects

Summary: [Commands] ObjectState enablement of actions broken for non IAdaptable objects

Status:	RESOLVED DUPLICATE of bug 156581

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.1.1
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Duong Nguyen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-02-15 13:19 EST by Jack Lynch
Modified:	2006-10-14 16:19 EDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jack Lynch

2006-02-15 13:19:20 EST

My model is an EMF one and consists of objects that implement EObject.  I've registed an IAdapterFactory for EObject to provide an IActionFilter for them via plugin.xml.

I've an Action that is enabled via objectState.  However, when an EObject is selected in my view the adapter factory is never consulted, let alone the IActionFilter.  

I believe it's because org.eclipse.ui.internal.ActionExpression$ObjectStateExpression in its isEnabledFor method never asks the PlatformManager for an adaptable for type IActionFilter on the selected object.  Basically if the selected object doesn't implement IAdaptable it doesn't work.

Regards,
Jack

Comment 1 Paul Webster

2006-10-14 16:19:43 EDT


*** This bug has been marked as a duplicate of 156581 ***