Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 127977 - [Presentations] [REGRESSION] Presentations fail to restore editor tab order
Summary: [Presentations] [REGRESSION] Presentations fail to restore editor tab order
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 62218
  Show dependency tree
 
Reported: 2006-02-15 02:32 EST by Gunnar Wagenknecht CLA
Modified: 2021-12-20 20:09 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2006-02-15 02:32:01 EST
I20060214-1600

While verifying bug 62218 I noticed that the 3.0 presentation also fails in restoring its tab order. Because the code in the R21 presentation did not change and looks similar to the 3.0 serialization code I think it's a problem in the underlying source.

Steps to reproduce:
- fresh workspace
- create simple project with three files (file1.txt, file2.txt, file3.txt)
- open all three files
- customize tab order
- close workbench
- reopen workbench
-> tab order is always "file1.txt, file2.txt, file3.txt"
Comment 1 Gunnar Wagenknecht CLA 2006-02-15 03:18:59 EST
The problem seems to on affect the editor presentation.

EditorManager#restoreState tries to restore the state of the editor presentation. During this the presentation is asked to restore its state, i.e. the tab order. This failes because the presentation will get no parts to restore. The EditorStack(PartStack) doesn't have any children. Thus, IPresentationSerializer#getPart(id) returns null for any of the ids to restore.

CCing Paul and Doug. It seems that this already popped up for the view tab order (bug 108033).
Comment 2 Paul Webster CLA 2006-04-25 14:07:31 EDT
Does this look familiar, Shaun?

PW
Comment 3 Paul Webster CLA 2006-09-28 15:17:33 EDT
Is this still a problem in 3.3?

PW
Comment 4 Markus Keller CLA 2006-09-29 06:33:36 EDT
Looks fixed once again in I20060926-0935. Since this problem reappears every once in a while for views and/or editors, I'm sure you already have regression tests for this, don't you?
Comment 5 Denis Roy CLA 2007-06-22 09:33:18 EDT
Changes requested on bug 193523
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:16:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 7 Eclipse Genie CLA 2021-12-20 20:09:04 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.