Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 127030 - Souce lookup doesn't work if underscore is in vesion qualifier
Summary: Souce lookup doesn't work if underscore is in vesion qualifier
Status: RESOLVED DUPLICATE of bug 120326
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-09 01:48 EST by David Williams CLA
Modified: 2006-02-09 14:50 EST (History)
1 user (show)

See Also:

Attachments
Version of runtime that does not replace _ by - (443.34 KB, application/octet-stream)
2006-02-09 09:04 EST, Pascal Rapicault CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2006-02-09 01:48:07 EST 
We've seen this problem on 3.1.2, and have documented it in 
Bug 89428

In that bug, it was recommend the "source lookup" problem should be examined by PDE UI team. 

While we have "worked around" the problem simply by not using the underscore in our version qualifiers, seems like a "bad bug" that might even be considered for fixing in a 3.1.3? The bug doesn't seem to happen if using 3.2 M4, so ... maybe there was some fix that could be tracked down and backported?
Comment 1 Wassim Melhem CLA 2006-02-09 03:41:39 EST 
this was fixed a while back in the 3.2 cycle.

*** This bug has been marked as a duplicate of 120326 ***
Comment 2 Pascal Rapicault CLA 2006-02-09 09:03:11 EST 
Even with a fixed version of runtime where the _ is not replaced by a - the problem still occurs. Could you please investigate?
I will attach a patched version of runtime 3.1.2.
Comment 3 Pascal Rapicault CLA 2006-02-09 09:04:15 EST 
Created attachment 34414 [details]
Version of runtime that does not replace _ by -
Comment 4 Wassim Melhem CLA 2006-02-09 14:50:03 EST 
Not sure what I am supposed to investigate nor why.  The problem is resolved correctly.

As I said in comment 1, the fix for the source lookup was to not use PluginVersionIdentifier but to use Version directly.

the JDT/Core plugins as they appear in 3.2 all have underscores in their versions, and we handle them correctly in the soure lookup.

So if you want this fix backported to 3.1.3, if one exists, we could do that.  but this is a certainly a dup of bug 120326 and should remain as that.

*** This bug has been marked as a duplicate of 120326 ***