Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 126907 - Add ICU support for Common Base Event Logging.
Summary: Add ICU support for Common Base Event Logging.
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Deadline: 2006-03-31
Assignee: Paul Slauenwhite CLA
QA Contact:
URL: http://www.eclipse.org/tptp/groups/Ar...
Whiteboard:
Keywords:
: 126084 (view as bug list)
Depends on: 126900 126902
Blocks: 123444
  Show dependency tree
 
Reported: 2006-02-08 09:24 EST by Paul Slauenwhite CLA
Modified: 2016-05-05 10:49 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Slauenwhite CLA 2006-02-08 09:24:55 EST
Add ICU4J support for Common Base Event Logging.

NOTE: Please see bug 123444 (or bug 120002) for more details.

The following Common Base Event Logging files require ICU support:

-EventHelpers.java (3 matches)
org.eclipse.hyades.logging.core/src.cbe101/org/eclipse/hyades/logging/events/cbe

-EventException.java (2 matches)
org.eclipse.hyades.logging.core/src.events/org/eclipse/tptp/logging/events/cbe/util

-EventHelpers.java (3 matches)
org.eclipse.hyades.logging.core/src.events/org/eclipse/tptp/logging/events/cbe

-EventException.java (2 matches)
org.eclipse.hyades.logging.parsers/src/org/eclipse/hyades/logging/parsers -
Comment 1 Paul Slauenwhite CLA 2006-02-08 09:33:33 EST
*** Bug 126084 has been marked as a duplicate of this bug. ***
Comment 2 Paul Slauenwhite CLA 2006-02-08 09:47:50 EST
I am having some issues with adding this ICU support to the Common Base Event implementations when they are often used for simple logging.  Already, we require two JARs for the non-EMF Java implementation and four JARs for the EMF Java implementation.  Adding the additional ICU JAR would deter users from using one of the Common Base Event implementations for simple logging.  

Furthermore, according to the ICU documentation, migration is more than using the ICU classes in place of the java.text.* and java.util.* classes (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=119410#c0).  According to the ICU documentation (http://icu.sourceforge.net/userguide/intro.html), all of the following TPTP function will require refactoring for ICU support:

-Chars & Strings
-Locales & Resources
-Date/Time
-Formatting 

Ultimately, the TPTP project should specify some ground rules/migration guide to ensure consistency and assist in our ICU support.

As such, retargetting to TPTP V4.2.0 (i2) to allow sufficient time to design, implement and test the solution.
Comment 3 Paul Slauenwhite CLA 2006-02-09 09:31:49 EST
See:

http://dev.eclipse.org/mhonarc/lists/tptp-pmc/msg01181.html
Comment 4 Sri Doddapaneni CLA 2006-03-08 18:32:01 EST
Part of #123444.
Comment 5 Sri Doddapaneni CLA 2006-04-03 11:37:33 EDT
What is the status?
Comment 6 Paul Slauenwhite CLA 2006-04-04 09:09:56 EDT
Will finish today or tomorrow BEFORE the Common Base Event JUnit tests are executed.
Comment 7 Paul Slauenwhite CLA 2006-04-06 17:44:23 EDT
Also, adding support for the com.ibm.icu.text.MessageFormat class.
Comment 8 Paul Slauenwhite CLA 2006-04-06 18:20:06 EDT
Added \org.eclipse.hyades.logging.core\src\org\eclipse\hyades\internal\logging\core\InternationalizationUtilities.java.
Comment 9 Paul Slauenwhite CLA 2006-04-07 14:14:05 EDT
This was quite a bit more work than originally estimated but now both Java Common Base Event implementations are ICU-enabled if the ICU binaries are on the classpath at run-time.  Otherwise, the default behaviour is to use the java.* classes with a very minor performance impact once it is determine that the ICU binaries are not on the classpath at run-time.  

The following files checked-in to CVS (HEAD) under the org.eclipse.haydes.logging.core plugin:

InternationalizationUtilities.java
LoggingCoreResourceBundle.java
LoggingCoreUtilities.java
XmlUtility.java
plugin.properties
EventException.java
AssociatedEventImpl.java
AssociationEngineImpl.java
AvailableSituationImpl.java
CommonBaseEventImpl.java
ComponentIdentificationImpl.java
ConfigureSituationImpl.java
ConnectSituationImpl.java
ContextDataElementImpl.java
CreateSituationImpl.java
DependencySituationImpl.java
DestroySituationImpl.java
EventFactoryImpl.java
EventFactoryObjectFactory.java
ExtendedDataElementImpl.java
FeatureSituationImpl.java
MsgCatalogTokenImpl.java
MsgDataElementImpl.java
OtherSituationImpl.java
ReportSituationImpl.java
RequestSituationImpl.java
SituationImpl.java
SituationTypeImpl.java
StartSituationImpl.java
StopSituationImpl.java
EventHandler.java
EventFormatter.java
EventHelpers.java
EventValidation.java
SetConfig.java
EventException.java
AssociatedEventImpl.java
AssociationEngineImpl.java
AvailableSituationImpl.java
CommonBaseEventImpl.java
ComponentIdentificationImpl.java
ConfigureSituationImpl.java
ConnectSituationImpl.java
ContextDataElementImpl.java
CreateSituationImpl.java
DependencySituationImpl.java
DestroySituationImpl.java
EventFactoryImpl.java
EventFactoryObjectFactory.java
ExtendedDataElementImpl.java
FeatureSituationImpl.java
MsgCatalogTokenImpl.java
MsgDataElementImpl.java
OtherSituationImpl.java
ReportSituationImpl.java
RequestSituationImpl.java
SituationImpl.java
SituationTypeImpl.java
StartSituationImpl.java
StopSituationImpl.java
EventHandler.java
EventFormatter.java
EventHelpers.java
Comment 10 Paul Slauenwhite CLA 2006-04-07 15:20:36 EDT
(In reply to comment #9)

Also:
ICUInternationalizationUtilities.java
JavaInternationalizationUtilities.java
Comment 11 Paul Slauenwhite CLA 2006-04-10 12:58:51 EDT
Verfied in TPTP-4.2.0-200604100100.