Community
Participate
Working Groups
This bugzilla is for the work to implement 109892 for the examples. (Separate examples into examples for users and examples for isv.) Assigning this enhancement to the default owner of the platform samples.
This should be completed in iteration 1.
Created attachment 34513 [details] Proposed changes to the examples to divide into examples for users & examples for isv
We have several examples in TPTP. Below is my proposed classification and new plug-in. Harm tells me that even though the examples themselves are not API, the plug-ins that they're contained in cannot be deleted because that would break Update Manager. The old plug-ins will be made blank and the existing features will not change. Instead, a new feature will be created that contains the doc.isv and examples.isv so that a consumer can easily pick up these ISV resources again, but the ISV resources cannot continue to be packaged with the runtime zip because the ISV resources are not translated. Proposed changes: Plug-ins that would be made blank (no code, only plugin.xml and plugin.properties if necessary): 1. org.eclipse.hyades.trace.sample 2. org.eclipse.hyades.logging.core.sample. Example: Analysis Engine Sample Currently in plug-in: org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Analyzer Extension Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Apache Commons Logging Sample Currently in plug-in:org.eclipse.hyades.logging.core.sample Classification (user or ISV): user Proposed new plug-in: org.eclipse.tptp.platform.examples Example: Apache Log4J Logging Sample Currently in plug-in:org.eclipse.haydes.logging.core.sample Classification (user or ISV): user Proposed new plug-in: org.eclipse.tptp.platform.examples Example: Column Extension Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Context Language Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: EMF Common Base Event v1.0.1 Sample Currently in plug-in:org.eclipse.hyades.logging.core.sample Classification (user or ISV): user Proposed new plug-in: org.eclipse.tptp.platform.examples Example: Export Viewer Generator Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Filter Type Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: JSR-047 Logging Sample Currently in plug-in:org.eclipse.hyades.logging.core.sample Classification (user or ISV): user Proposed new plug-in: org.eclipse.tptp.platform.examples Example: Log Correlator Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Log Parser Extension Sample Currently in plug-in:org.eclipse.haydes.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Log Parser Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv Example: Navigator Extension Sample Currently in plug-in:org.eclipse.hyades.logging.core.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.platform.examples.isv (Can't be put into the trace.examples.isv because that's in the Monitoring project while this example is in the Platform project.) Example: Probekit Compile Extension Sample Currently in plug-in:org.eclipse.hyades.trace.sample Classification (user or ISV): ISV Proposed new plug-in: org.eclipse.tptp.trace.examples.isv
After speaking with Valentina, I understand that the Probekit example should be removed, and the attachment has it removed. The attachment also contains the fix to three examples: 1. LogAnalyzerProject This project couldn't be created due to a null in the WizardNewProjectCreationPage::getLocationPath() method (the locationArea field was null). The fix was to override the method because the locationArea field is initialized in a method that is overriden by the LogAnalyzerSamplePage. 2. LogParserExtensionSample The created example project had compile errors due to missing ICU classes in the classpath. The fix was to update the plugin.xml file to import the com.ibm.icu plug-in. 3. LogParserProject The created example project had compile errors due to missing ICU classes in the classpath. The fix was to update the plugin.xml file to import the com.ibm.icu plug-in.
Created attachment 34625 [details] Code that shows the new plug-ins for the examples
Created attachment 34885 [details] Latest version of proposed examples split As per Paul's comments, the Apache Log Correlation/Analyzer Sample has been reclassified from "ISV" to user. The documentation was moved back into org.eclipse.tptp.monitoring.doc.user and the example was moved into org.eclipse.tptp.monitoring.examples.
Comment on attachment 34885 [details] Latest version of proposed examples split I just discovered a bug in the migration...deleting this file for now, will attach a new zip once the bug is fixed.
Created attachment 34886 [details] The latest samples The attached zip contains the latest reclassification of the samples with the bug fixed.
Examples checked in with Dave's permission. I think that they've been reviewed by everyone under the sun. ;o)
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
