Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 124942 - [WorkbenchParts] (regression) Order of placeholder lost
Summary: [WorkbenchParts] (regression) Order of placeholder lost
Status: RESOLVED DUPLICATE of bug 181729
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 153957
  Show dependency tree
 
Reported: 2006-01-23 16:24 EST by Nick Edgar CLA
Modified: 2007-05-14 14:24 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2006-01-23 16:24:48 EST
build I20060118

- in the Java perspective, arrange the left folder to have the Package Explorer and Plugins views, in that order
- close the Package Explorer
- show the Package Explorer
- it's added to the right of the Plugins view

It apparently correctly left a placeholder (otherwise the PE would have appeared at bottom right), but lost the order.

This used to work, e.g. at least in Eclipse 2.1.
Comment 1 Paul Webster CLA 2006-09-28 15:17:27 EDT
Is this still a problem in 3.3?

PW
Comment 2 Nick Edgar CLA 2007-03-02 13:59:05 EST
Yes, still a problem.  In addition, the order of tabs is not preserved between sessions (which is arguable a worse problem than this one).
Comment 3 Nick Edgar CLA 2007-03-02 13:59:33 EST
I would really like to see these two issues fixed for 3.3.
Comment 4 Nick Edgar CLA 2007-03-02 14:00:08 EST
Let me know if I can help.
Comment 5 Paul Webster CLA 2007-03-02 14:04:57 EST
Eric, did you see anything obvious about this in your travels?

It's some startup order issues between the PartStack, the IPresentationSerializer, and PresentationFactoryUtil.createPresentation(*)

IIRC at the point the serializer was filling the PartStack the info wasn't available, so it ended up with a sorted list of 0 ... then actually added enough information to sort.

But that was a long time ago :-)

PW
Comment 6 Eric Moffatt CLA 2007-03-05 14:07:06 EST
This has been the standard behavior since I've been here (i.e. post-3.0). Closing a view in a stack and then re-opening it will place it at the end of the CTabFolder's list...

Also, Nick's just repro'd the order change...the basic scenario was to have a set of view tabs on the bottom stack in the Java perspective (with the Bookmarks view being left-most). Open the Debug perspective then shut down, restart and switch back to the Java perspective. Unfortunately even when I follow these steps I haven't been able to cause it to happen...but I -have- seen it...

Comment 7 Eric Moffatt CLA 2007-03-05 14:36:32 EST
I can repro this using the new min/max...

Similar scenario but simpler:

Start with a clean workspace with the new 3.3 presentation on
Add Bookmark view to bottom stack
Drag to be left-most view

shut down / restart (everything is OK)

Minimize the stack
Restore the stack

shut down / restart (Bookmark view is now the right-most tab)

Paul, I'll grab this one. The problem has been there for longer than the new min/max story but I'm in a good position to track it down...and it makes a good test case to verify that I'm managing the presentation model correctly.

Comment 8 Eric Moffatt CLA 2007-03-16 10:12:48 EDT
*** Bug 177518 has been marked as a duplicate of this bug. ***
Comment 9 Eric Moffatt CLA 2007-03-19 10:16:31 EDT
This is a once-off; likely an initialization rather than a storage issue. After the first restore it appears to work correctly...

deferring to M7
Comment 10 Markus Keller CLA 2007-03-19 10:37:41 EDT
> This is a once-off; likely an initialization rather than a storage issue. After
> the first restore it appears to work correctly...

That's correct for the problem in bug 177518, but not for comment 0 (which is only about reopening a closed view at the same spot). I think bug 177518 should not be a dup of this one.

Comment 7 is also reproducible and should be a separate bug (since it happens across sessions and not in one session as comment 0).

Separating the individual problems should also make it easier to catch these reoccurring issues in regression tests once and for all.
Comment 11 Markus Keller CLA 2007-04-10 05:26:42 EDT
I filed bug 181729 for comment 7, since it is a different scenario, is new in 3.3, and requires a separate regression test.
Comment 12 Eric Moffatt CLA 2007-04-24 11:27:40 EDT
The tab ordering cross session issues have been resolved I think (see bug 181729). 

The close/reopen behavior won't be addressed in 3.3.

I'm not quite sure what to do to get this off my 3.3 plate; the cross session re-ordering is fixed but the original scenario is not...Comments?

Comment 13 Nick Edgar CLA 2007-04-24 11:47:34 EDT
If you think it may be addressed later, then just clear the Target Milestone, and maybe mark it as Resolved > Later if you want it out of your bucket.  Otherwise, just close as WONTFIX. 

While I liked the old behaviour where it remembered a placeholder when you closed the view, I'm not going to argue about it.
Comment 14 Eric Moffatt CLA 2007-04-30 11:02:38 EDT
Nick , upon checking around it turns out that the 'always open as right-most tab' may be intentional; it's more deterministic than inserting the view into the tab list at some other (potentially arbitrary) location.

I've moved bug 177518 to a more accurate defect, leaving this one free to be determined post-3.3 and changingthe target accordingly...
Comment 15 Eric Moffatt CLA 2007-05-14 14:24:11 EDT

*** This bug has been marked as a duplicate of bug 181729 ***