Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 124222 - BugzillaTaskExternalizer creates elements for non-bugzilla queries
Summary: BugzillaTaskExternalizer creates elements for non-bugzilla queries
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-17 18:24 EST by Wesley Coelho CLA
Modified: 2006-01-17 21:52 EST (History)
0 users

See Also:

Attachments
Patch for bugzilla.ui (925 bytes, patch)
2006-01-17 18:24 EST, Wesley Coelho CLA 		no flags Details | Diff
Patch for tasklist (1.53 KB, patch)
2006-01-17 18:25 EST, Wesley Coelho CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley Coelho CLA 2006-01-17 18:24:16 EST 
The BugzillaTaskExternalizer lacks an overriding method to specify the kinds of ITaskQueries that it can create elements for. Also, the ComboSelectionDialog class could use an extra method that returns the index of the selected string. I will submit the following patches:

- bugizilla.ui: Adds an overriding method to BugzillaTaskExternalizer so that 
canCreateElementFor(ITaskQuery category) only returns true if category is
an instance of BugzillaQueryCategory. The superclass implementation was always
returning true.

Testing:
- Manually created a bugzilla task and a query and restarted Eclipse to
ensure that they are still there.
- All automated test cases pass

----

- tasklist: Added a "getter" to the ComboSelectionDialog so that the index of the selected string is returned.

Testing:
- Manually used the ComboSelectionDialog to add planned tasks to a cateogory.
- All automated test cases pass
Comment 1 Wesley Coelho CLA 2006-01-17 18:24:51 EST 
Created attachment 33181 [details]
Patch for bugzilla.ui
Comment 2 Wesley Coelho CLA 2006-01-17 18:25:12 EST 
Created attachment 33182 [details]
Patch for tasklist
Comment 3 Wesley Coelho CLA 2006-01-17 18:26:29 EST 
(There were other changes but they were just name refactorings so I left that part as-is)
Comment 4 Mik Kersten CLA 2006-01-17 21:52:37 EST 
Thanks for being clear on the testing.  Yes, this was a bug in the BugzillaTaskExternalizer.