Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 123965 - [Preferences] Cancelling Compiler Error/Warning property page still puts them in effect
Summary: [Preferences] Cancelling Compiler Error/Warning property page still puts them...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-16 10:01 EST by Shaun Skelton CLA
Modified: 2006-02-13 16:23 EST (History)
1 user (show)

See Also:

Attachments
Error Settings Window (37.92 KB, image/png)
2006-01-16 10:02 EST, Shaun Skelton CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Skelton CLA 2006-01-16 10:01:52 EST 
Eclipse 3.2 M4
When changing the "Non-externalized strings" field (under properties -> java compiler -> Errors/Warnings) from Ignore to Error a message appears stating that a project rebuild is required for the changes to take effect. Unfortunately, the rebuild still occurs even if the user clicks Cancel. Also, once the cancel button returns the user to the settings window the OK button is no longer available and the user must click the cancel button. Futhermore, even after the cancel button is clicked, the setting changes are still put into effect.
Comment 1 Shaun Skelton CLA 2006-01-16 10:02:19 EST 
Created attachment 33069 [details]
Error Settings Window
Comment 2 Martin Aeschlimann CLA 2006-01-17 04:56:53 EST 
Could reproduce in 20060117

- enable autobuild
- select a project, open properties
- Java Compiler - Error/Warnings, change the first setting
- press OK
- On the dialog press 'Cancel'

- observe a build in the workbench toolbar (set a  breakpoint in AutoBuildJob.build(boolean) line: 71)

In the stacktrace you can see that
  PropertyDialog(FilteredPreferenceDialog).okPressed() line: 298
does a workingCopyManager.applyChanges();
but better shouldn't, as one of the pages oks failed before (done in super.okPressed())

Also the OK button should not be disabled when returning to the page.

Same problem in the preference page.
Comment 3 Tod Creasey CLA 2006-02-08 10:57:26 EST 
We should have been using the return codes from super to see if we should continue.

Fixed in build >20060208
Comment 4 Tod Creasey CLA 2006-02-13 16:23:21 EST 
Verified in 20060213-1200