Comment 1 Robert Elves 2006-02-28 18:33:04 EST

Created attachment 35513 [details]
Fixed. Repository versions now associated with each TaskRepository

Includes a number of fixes to product parsing including removal of ProductParser.java and additional dead code. Tests make use of new test repositories at mylar.eclipse.org.  Tests should be updated to use HTTPS when available.

Comment 2 Mik Kersten 2006-02-28 19:16:01 EST

To make synchronization easier I've applied this patch.  UI looks good.  But some quick testing raised the following problems:

* The version set for each repository has to be that which was set in the old preference page.  Otherwise everyone who upgrades but is using 2.16 or 2.18 will have their queries break unexpectedly.

* 2.20.1 should not be a version, since we support both 2.20 and 2.20.1 with the same code and users should not need to care about this

* If I have 2.20.1 selected I get only a single query hit returned for an eclipse.org query that should return many.  Having 2.20 selected worked fine.

Comment 3 Robert Elves 2006-02-28 19:34:30 EST

Great, thanks for the feedback Mik. I'll make those changes now. In regard to retrieving the previous version of Bugzilla used, where would you suggest the code go for retrieving the legacy version setting if available? The repository agnostic TaskRepositoryManager doesn't quite seem like the correct place. Thoughts?

Comment 4 Mik Kersten 2006-02-28 19:38:15 EST

No, it shouldn't go into mylar.tasklist because that plug-in can't even see bugzilla preference store.  You might want to put it into the BugzillaRepositoryConnector, or alternatively into a method like BugzillaPlugin.migrateOldAuthenticationData that gets called if there is a previous versoin specified, then after running sets that preference value to "" so that it never runs again.

Comment 5 Robert Elves 2006-02-28 21:40:07 EST

Created attachment 35519 [details]
Fixed oustanding issues regarding migration and versions

Migration handled within BugzillaPlugin.start()

Comment 6 Robert Elves 2006-02-28 23:03:41 EST

Created attachment 35523 [details]
Migration moved to BugzillaRepositoryConnecctor

Comment 7 Mik Kersten 2006-03-01 11:06:37 EST

Patch applied.  Did some quick testing and looking good.  

Comment 8 Mik Kersten 2006-03-01 13:52:46 EST

Nice work Rob!

Comment 9 Robert Elves 2006-03-02 14:05:49 EST

Created attachment 35632 [details]
Persists version upon migration to avoid loss of data in event of workbench crash

Comment 10 Mik Kersten 2006-03-02 15:13:58 EST

Patch applied.