Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 121894 - [Browser] Events being sent out while disposing Browser
Summary: [Browser] Events being sent out while disposing Browser
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-22 11:01 EST by Benjamin Pasero CLA
Modified: 2006-03-30 12:12 EST (History)
0 users

See Also:

Attachments
Complete stacktrace (5.41 KB, text/plain)
2005-12-22 11:02 EST, Benjamin Pasero CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Pasero CLA 2005-12-22 11:01:17 EST 
This is a problem I often come along when disposing the Browser. In some situations it looks as if browser-events like WindowEvents are sent out, even though the Browser is in the process of being disposed.

A common stacktrace of this situation looks like:

[snip]
at org.eclipse.swt.browser.Browser$2.handleEvent(Browser.java:350)
at org.eclipse.swt.ole.win32.OleEventTable.sendEvent(OleEventTable.java:55)
at org.eclipse.swt.ole.win32.OleEventSink.notifyListener(OleEventSink.java:144)
at org.eclipse.swt.ole.win32.OleEventSink.Invoke(OleEventSink.java:119)
at org.eclipse.swt.ole.win32.OleEventSink.access$1(OleEventSink.java:96)
at org.eclipse.swt.ole.win32.OleEventSink$1.method6(OleEventSink.java:70)
at org.eclipse.swt.internal.ole.win32.COMObject.callback6(COMObject.java:117)
at org.eclipse.swt.internal.win32.OS.VtblCall(Native Method)
at org.eclipse.swt.internal.ole.win32.IOleInPlaceObject.InPlaceDeactivate(IOleInPlaceObject.java:21)
at org.eclipse.swt.ole.win32.OleClientSite.deactivateInPlaceClient(OleClientSite.java:524)
at org.eclipse.swt.ole.win32.OleClientSite.onDispose(OleClientSite.java:825)
at org.eclipse.swt.ole.win32.OleClientSite.access$1(OleClientSite.java:821)
at org.eclipse.swt.ole.win32.OleClientSite$1.handleEvent(OleClientSite.java:125)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:884)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:908)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:889)
at org.eclipse.swt.widgets.Widget.release(Widget.java:710)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:614)
[snip]

Is this by intention?
Ben
Comment 1 Benjamin Pasero CLA 2005-12-22 11:02:42 EST 
Created attachment 32145 [details]
Complete stacktrace

The Complete stacktrace
Comment 2 Benjamin Pasero CLA 2005-12-23 05:25:14 EST 
I am just remembering that there seems to be a JavaScript event-trigger that requests to open a new page when the Browser is closing. 

This may result in an application using a Browser shutting down, but bringing up a new Browser meanwhile.

Ben
Comment 3 Grant Gayed CLA 2006-03-29 16:56:51 EST 
fixed in HEAD > 0329

I'm not sure if this will be in 3.2M6 or not, so leaving Target Milestone unset for now.

- null check added
- related report: bug 121892
Comment 4 Benjamin Pasero CLA 2006-03-30 01:13:55 EST 
Thanks! Looks like a pretty straightforward change. Would be nice if it was included in M6.

Ben
Comment 5 Grant Gayed CLA 2006-03-30 11:35:22 EST 
Since we're submitting a few other M6 changes, this one has joined in.
Comment 6 Benjamin Pasero CLA 2006-03-30 12:12:38 EST 
Great!