Community
Participate
Working Groups
It has been reported in the bug #102028 that the branding of the launcher with bmp files does not seem to work. We need to investigate this and see what is going on here.
Branding works fine if the correct size of bitmaps are provided. We can only brand sizes that match those already in the launcher exe. The Launcher tab of the product editor needs to be updated to reflect the bitmap sizes currently in the launcher. These sizes are: 16x16 8bit (256 color) 16x16 32bit (True color) 24x24 8bit 32x32 32bit 32x32 8bit 48x48 32bit 48x48 8bit When these changes are made, pde.build will need to make sure it can still read the .product file if there are format changes.
JLB, we need to: 1. change the text in the win32 section of the editor to reflect the correct size and depth as per comment 1. Existing attributes do not need to be modified. 2. we need to add one new attribute to the product file to store the 24x24 8-bit image location.
I've got the code ready for the extra field but I would like to post a followup before I commit. Since we've switched (or corrected?) over to 8-bit/32-bit (from the old 4-bit/8-bit) I havent been able to create a 32-bit bmp file to test the validation - do we need to go as high as 32-bit? Would it be alright if we dropped down to 24-bit, since it also supports better display standards for bitmap files? Thanks
Created attachment 35547 [details] bitmaps for testing Attached are the 32 bit icons I was using to test. Because we can only replace image sizes that already exist in the exe, the launcher would need to be switch to 24bit before we could use that size. I don't know how long the launcher has used 32b, but if we changed, that would break any existing people who have working ico files (or managed to figure out the bitmaps) Also, I don't know if the validation of the ico file checks the image sizes it contains, but it needs to match the given sizes as well.
Fixed up to include the 24x24 8-bit file. Validation of the .ico file has been updated to check for 7 images - further .ico validation will be documented using bug #118811.
It's cool that you have fixed what you have. However, what one really wants is to be able to replace the icons with any .ico file. Since this bug is closed, I am submitting the rest of this comment in Bug #118811.
