Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 121649 - [internal API] Agent and Process (plus 3 others) must be made public
Summary: [internal API] Agent and Process (plus 3 others) must be made public
Status: CLOSED DUPLICATE of bug 136985
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Samson Wai CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-20 18:07 EST by Jeff Nevicosi CLA
Modified: 2016-05-05 10:50 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Nevicosi CLA 2005-12-20 18:07:50 EST
5 classes:

org.eclipse.hyades.internal.execution.local.control.Agent
org.eclipse.hyades.internal.execution.local.control.Process
org.eclipse.hyades.internal.execution.local.control.ProcessImpl
org.eclipse.hyades.internal.execution.local.common.DataServerListener
org.eclipse.hyades.internal.execution.local.control.InactiveProcessException


are in internal packages and must be made public in order for consuming product to use.

These are all being used in an attempt to use interface IExecutionHarnessDataProcessor.  These methods must be implemented in order to use this interface:

public void setControlAgent(Agent theAgent);
public void setProcess(Process process);

In addition, there are other related internal class that are referenced directly, but they are used much less globally, and it may be possible to refactor other classes instead of making them public.

ProcessImpl:  calling the getlocation() method is required, but not available in Process.

DataServerListener: to handle the dataServerExited() event

InactiveProcessException:  this is thrown from Process.getProcessId(), so must be caught.

consuming product will require in 4.2.
Comment 1 Sri Doddapaneni CLA 2006-04-12 10:53:38 EDT
We are at feature freeze stage for 4.2. I sugget this is taken up for 4.3. If this is not acceptable, please work with the committers for other accomodations in 4.2.
Comment 2 Hendra Suwanda CLA 2006-05-08 09:08:24 EDT
Adding the following classes to the list:

org.eclipse.hyades.internal.execution.local.control.Application;
org.eclipse.hyades.internal.execution.local.control.Node;
org.eclipse.hyades.security.internal.util.ConnectUtil;
org.eclipse.hyades.internal.execution.local.common.CustomCommand;
Comment 3 Samson Wai CLA 2006-10-30 10:27:26 EST
Not containable in 4.3 and retarget to 4.4. Please let me know if you have any concern.
Comment 4 Samson Wai CLA 2007-01-31 12:17:06 EST
Retarget to future due to resource limitation.
Comment 5 Jeff Nevicosi CLA 2007-02-15 13:35:01 EST
Not sure if this defect was overlooked in the recent discussions re: internal API, but I feel that Paul's comments...

>Please provide a detailed list of the required public classes with an
explanation on why they are required to be public.  After we review, we will
reconsider this defect for 4.4 given we have sufficient time to complete before
API freeze (March 16, 2007).


...were sufficiently explained in the opening comment of this defect.  Please reconsider fixing in 4.4.
Comment 6 Natasha D'Silva CLA 2007-05-10 11:19:31 EDT
Also, add 
org.eclipse.hyades.internal.execution.local.control.ProcessListener to this list because any custom data collectors need to register listeners with the process so they can handle processLaunch and processExited events.
Comment 7 Samson Wai CLA 2007-06-11 10:25:05 EDT
Dup of bug 136985.

*** This bug has been marked as a duplicate of bug 136985 ***
Comment 8 Jeff Nevicosi CLA 2007-06-28 11:55:35 EDT
closing as duplicate