Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 121623 - [Decorators] Patch to support logical model decoration
Summary: [Decorators] Patch to support logical model decoration
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-20 15:32 EST by Michael Valenta CLA
Modified: 2006-02-13 15:35 EST (History)
0 users

See Also:


Attachments
Here's the patch (52.42 KB, patch)
2005-12-20 15:35 EST, Michael Valenta CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2005-12-20 15:32:15 EST
In order to properly support the decoration of logical model elements with repository state, we need to have a tighter coupling of the sync decoration (i.e. the > prefix) and the viewer showing the model. This is not overly complex but we must maintain backwards compatibility. To do this, we need a way for a viewer (via it's label provider) to say that it will handle the sync decoration. If the label provider handles sync decoration, the lightweight decorator should not. If the label provider does not, the lightweight decorator shoudl still do the decoration.

To support this, I have modifed JFace and Wokbench to pass a decoration context from the decorating label provider through to the lightweight decorators. I will attach what I have done so far for comment.
Comment 1 Michael Valenta CLA 2005-12-20 15:35:23 EST
Created attachment 32039 [details]
Here's the patch

The patch adds an ILabelDecorator2 that accepts an IDecorationContext to all the decoration methods. It also modifes JFace and Woekbench to pass the context from the DecoratingLabelProvider through the the label decorators.
Comment 2 Michael Valenta CLA 2005-12-20 15:37:06 EST
I also removed the stuff we added earlier in 3.2 sinece we abandoned that approach (although you may want to double check to make sure I got it all).
Comment 3 Tod Creasey CLA 2006-01-05 13:09:18 EST
Patch has been released with some javadoc tidyup and moving ILabelDecorator to an abstract superclass LabelDecorator.
Comment 4 Tod Creasey CLA 2006-02-13 15:35:16 EST
Verified in 20060113-1200 by code inspection