Community
Participate
Working Groups
build I20051206 As we did for editor tabs (see bug 32789), we should allow control over the amount of compression of view tabs before switching to chevron mode. Since the set of views in a folder is much more stable than for editors, view folders should tolerate much more compression (e.g. 1 character) before switching to the chevron, so as to interfere less with users' positional memory.
Created attachment 31388 [details] Suggested patch Boris and Doug, what do you think of this patch?
See also bug 113151 for more context.
There's a cut and paste error in the patch: + * Workbench preference identifier for the minimum width of editor tabs. should be + * Workbench preference identifier for the minimum width of view tabs.
Created attachment 31409 [details] Patch to o.e.ui This is needed too.
+1 from me.
Sorry - I didn't realize that this bug was assigned to me. I'll apply the patch after M4 is declared unless anyone objects. Thanks for the patch, Nick!
Post-M4 is fine.
The patch looks fine. One thought though: it would be better if the icon stayed in preference to the character. Try compressing the tab folder a lot, and you're left with only single characters: P, V, O. I find the icon a better visual cue.
I agree. Currently we only show the icon for the active tab, though, so we would have to go back on that for consistency. Also, I think the "..." could be dropped in favour of just clipping.
I committed the original patch from Nick (without the cut and paste error). I think not showing icons on inactive views was a conscious design decision. We would need to discuss this from a UI design viewpoint. The "..." is hardwired into CTabFolder, removing it would require a change to SWT. Released >20060123.
As for comment #9, I agree we should consider a method where we compress to the icons first. However it was a decision not to put the icons in the background folders to help bring out the selected folder more. Before 3.0 there were problems with users not being able to see which editor was the active editor and same for views. So this should be considered if we put icons back in the tabs.
Maybe use grey versions of the icons for inactive views?
Reopening in order to discuss further whether we should show icons for all views.
at this point I think we should only be discussing the text behaviour and making modifications to CTabFolder or our code that sets text bounds etc... It's not a good idea to switch to using icons at this late stage. We should add this to the 3.3 design item list.
not going to icons etc... for 3.2
We are now always showing icons for views.
