Bug 118153 - [implementation] Enable AbstractRulerActionDelegate for multi-page editor scenario
Summary: [implementation] Enable AbstractRulerActionDelegate for multi-page editor sce...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1.2   Edit
Assignee: Dani Megert CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-27 11:54 EST by Dani Megert CLA Friend
Modified: 2006-01-11 05:37 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA Friend 2005-11-27 11:54:16 EST 
3.1.1

AbstractRulerActionDelegate.setActiveEditor(...) assumes that the given top-level editor part is a text editor and does not work if this is a multi-page editor.

In order to support the mpe scenario we need to use an adapter here.
Comment 1 Dani Megert CLA Friend 2005-11-27 12:33:21 EST 
If a CU editor was used in a mpe it was possible to set breakpoints in 3.0. This no longer works in 3.1 due to changes in Platform UI. Making the AbstractRulerActionDelegate more flexible resolves this issue.

The fix is trivial and low risk.
Approving for 3.1.2.
Comment 2 Dani Megert CLA Friend 2005-11-28 06:15:25 EST 
Fix reviewed by Martin.
Committed to HEAD and R3_1_maintenance.
In builds > N20051128-0010 and > M20051123-0800.

Bruce, can you verify this bug using upcoming M20051130-0800? Thanks.
Comment 3 Tom Hofmann CLA Friend 2006-01-11 05:17:17 EST 
verifying...
Comment 4 Tom Hofmann CLA Friend 2006-01-11 05:37:37 EST 
Verified that the code is in the M20060109-1200 build. Verified the 'Add Bookmark' actions still appear in the normal Java, Text, and Manifest Source editors. Verified that editors implementing ITextEditor directly still work due to the platform's adapter mechanism.

Marking as verified.